jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/376458 )
Change subject: ContribsPager: Check if target is an IP range outside foreach loop ...................................................................... ContribsPager: Check if target is an IP range outside foreach loop Follow up to https://gerrit.wikimedia.org/r/#/c/376449/ Change-Id: I5151c10569a92805f79b59f68f9c57c451dc4598 --- M includes/specials/pagers/ContribsPager.php 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: MaxSem: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/specials/pagers/ContribsPager.php b/includes/specials/pagers/ContribsPager.php index 31ea810..979460c 100644 --- a/includes/specials/pagers/ContribsPager.php +++ b/includes/specials/pagers/ContribsPager.php @@ -384,6 +384,7 @@ $parentRevIds = []; $this->mParentLens = []; $batch = new LinkBatch(); + $isIpRange = $this->isQueryableRange( $this->target ); # Give some pointers to make (last) links foreach ( $this->mResult as $row ) { if ( isset( $row->rev_parent_id ) && $row->rev_parent_id ) { @@ -394,7 +395,7 @@ if ( $this->contribs === 'newbie' ) { // multiple users $batch->add( NS_USER, $row->user_name ); $batch->add( NS_USER_TALK, $row->user_name ); - } elseif ( $this->isQueryableRange( $this->target ) ) { + } elseif ( $isIpRange ) { // If this is an IP range, batch the IP's talk page $batch->add( NS_USER_TALK, $row->rev_user_text ); } -- To view, visit https://gerrit.wikimedia.org/r/376458 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5151c10569a92805f79b59f68f9c57c451dc4598 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: MusikAnimal <[email protected]> Gerrit-Reviewer: Florianschmidtwelzow <[email protected]> Gerrit-Reviewer: Legoktm <[email protected]> Gerrit-Reviewer: MaxSem <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
