Jhernandez has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/379201 )

Change subject: Chore: Fix spacing variable to a number
......................................................................

Chore: Fix spacing variable to a number

Instead of being based on font size. Design specified they should be
independent, and agreed that 15 was a good starting point.

Change-Id: I460da518c5a23f91f54f6e37f9881e0d359dc97f
---
M src/client/index.css
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/marvin refs/changes/01/379201/1

diff --git a/src/client/index.css b/src/client/index.css
index a1676b9..6984247 100644
--- a/src/client/index.css
+++ b/src/client/index.css
@@ -19,7 +19,7 @@
   --font-family-base: var(--font-family-sans);
 
   /* TODO: Upstream to wikimedia-ui-base once reviewed by design */
-  --space: var(--font-size-base);
+  --space: 15px;
 
   /* TODO: Upstream to wikimedia-ui-base once reviewed by design */
   --box-shadow-paper: 0 1px 3px 0 rgba( 0, 0, 0, 0.1 );

-- 
To view, visit https://gerrit.wikimedia.org/r/379201
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I460da518c5a23f91f54f6e37f9881e0d359dc97f
Gerrit-PatchSet: 1
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Jhernandez <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to