Mholloway has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379225 )
Change subject: Fix: Pass remaining sections from XHR back to the Java layer
......................................................................
Fix: Pass remaining sections from XHR back to the Java layer
Fixes a crash caused by our not augmenting the page model with info
from the remaining sections request for mobileview responses since the
introduction of XHR loading.
Bug: T176166
Change-Id: Ib172088c3ae5553a55fdcc90c5e7b29dd2158b92
---
M app/src/main/assets/bundle.js
M www/js/sections.js
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/25/379225/1
diff --git a/app/src/main/assets/bundle.js b/app/src/main/assets/bundle.js
index 08f4656..7700d77 100644
--- a/app/src/main/assets/bundle.js
+++ b/app/src/main/assets/bundle.js
@@ -466,7 +466,7 @@
}
document.getElementById( "loading_sections").className = "";
lazyLoadTransformer.loadPlaceholders();
- bridge.sendMessage( "pageLoadComplete", { "sequence": sequence });
+ bridge.sendMessage( "pageLoadComplete", { "sections": json.sections,
"sequence": sequence });
}
var remainingRequest;
diff --git a/www/js/sections.js b/www/js/sections.js
index a84c5db..464c94e 100644
--- a/www/js/sections.js
+++ b/www/js/sections.js
@@ -223,7 +223,7 @@
}
document.getElementById( "loading_sections").className = "";
lazyLoadTransformer.loadPlaceholders();
- bridge.sendMessage( "pageLoadComplete", { "sequence": sequence });
+ bridge.sendMessage( "pageLoadComplete", { "sections": json.sections,
"sequence": sequence });
}
var remainingRequest;
--
To view, visit https://gerrit.wikimedia.org/r/379225
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib172088c3ae5553a55fdcc90c5e7b29dd2158b92
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
