jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/379204 )
Change subject: Chore: Fix line height on Page-title for Page template
......................................................................
Chore: Fix line height on Page-title for Page template
It should have heading line height to have proper spacing.
Change-Id: I9296ee34b3454b08a3275b6b2eec2b0f8d7712f2
---
M src/common/components/page/page.css
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Niedzielski: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/common/components/page/page.css
b/src/common/components/page/page.css
index 0b40cbe..c819516 100644
--- a/src/common/components/page/page.css
+++ b/src/common/components/page/page.css
@@ -8,6 +8,7 @@
/* TODO: Extract to typography components once we have the specs */
font-size: var(--font-size-h4);
font-weight: bold;
+ line-height: var(--line-height-heading);
}
.Page-subtitle {
--
To view, visit https://gerrit.wikimedia.org/r/379204
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9296ee34b3454b08a3275b6b2eec2b0f8d7712f2
Gerrit-PatchSet: 2
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Jhernandez <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
