MaxSem has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379271 )
Change subject: Yet another attempt to fix the populateIpChanges script
......................................................................
Yet another attempt to fix the populateIpChanges script
It would seem we'd need to update $blockStart if there are no results
for a given block, and more importantly, continue and not break!
Bug: T175962
Change-Id: Ice1bdae3d16cf365da14c6df0e8d91d2b954e064
(cherry picked from commit ffba23d177d5eee876bdc59cdf1b945281b18041)
---
M maintenance/populateIpChanges.php
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/71/379271/1
diff --git a/maintenance/populateIpChanges.php
b/maintenance/populateIpChanges.php
index 17f49ee..f7bcc12 100644
--- a/maintenance/populateIpChanges.php
+++ b/maintenance/populateIpChanges.php
@@ -88,7 +88,8 @@
$numRows = $rows->numRows();
if ( !$rows || $numRows === 0 ) {
- break;
+ $blockStart = $blockEnd + 1;
+ continue;
}
$this->output( "...checking $numRows revisions for IP
edits that need copying, " .
--
To view, visit https://gerrit.wikimedia.org/r/379271
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice1bdae3d16cf365da14c6df0e8d91d2b954e064
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.30.0-wmf.19
Gerrit-Owner: MaxSem <[email protected]>
Gerrit-Reviewer: MusikAnimal <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
