jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/379283 )
Change subject: Chore: Improve structure of components/Page ...................................................................... Chore: Improve structure of components/Page Move the use of the Paper component *inside* the component's root element. Having it outside seems weird semantically. Change-Id: I8f53151ec3d8124ce3df691d0477ba3321ef3bcc --- M src/common/components/page/page.tsx 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Niedzielski: Looks good to me, approved jenkins-bot: Verified diff --git a/src/common/components/page/page.tsx b/src/common/components/page/page.tsx index 6fea60a..bcbed7b 100644 --- a/src/common/components/page/page.tsx +++ b/src/common/components/page/page.tsx @@ -14,15 +14,15 @@ children }: Props): JSX.Element { return ( - <Paper> - <div class="Page"> + <div class="Page"> + <Paper> <div class="Page-header"> <div class="Page-title">{title}</div> <div class="Page-subtitle">{subtitle}</div> </div> {children && <Separator />} <div class="Page-content">{children}</div> - </div> - </Paper> + </Paper> + </div> ); } -- To view, visit https://gerrit.wikimedia.org/r/379283 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f53151ec3d8124ce3df691d0477ba3321ef3bcc Gerrit-PatchSet: 1 Gerrit-Project: marvin Gerrit-Branch: master Gerrit-Owner: Jhernandez <jhernan...@wikimedia.org> Gerrit-Reviewer: Niedzielski <sniedziel...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits