Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379296 )
Change subject: Set wgUseRCPatrol in ChangesListSpecialPageTest
......................................................................
Set wgUseRCPatrol in ChangesListSpecialPageTest
wgUseRCPatrol = false makes the tests fail
Change-Id: I18965d33171137ff182800512c8c0e8e63de124e
---
M tests/phpunit/includes/specialpage/AbstractChangesListSpecialPageTestCase.php
M tests/phpunit/includes/specialpage/ChangesListSpecialPageTest.php
2 files changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/96/379296/1
diff --git
a/tests/phpunit/includes/specialpage/AbstractChangesListSpecialPageTestCase.php
b/tests/phpunit/includes/specialpage/AbstractChangesListSpecialPageTestCase.php
index b101857..ad94f6f 100644
---
a/tests/phpunit/includes/specialpage/AbstractChangesListSpecialPageTestCase.php
+++
b/tests/phpunit/includes/specialpage/AbstractChangesListSpecialPageTestCase.php
@@ -16,10 +16,11 @@
protected $oldPatrollersGroup;
protected function setUp() {
- global $wgGroupPermissions;
-
parent::setUp();
- $this->setMwGlobals( 'wgRCWatchCategoryMembership', true );
+ $this->setMwGlobals( [
+ 'wgRCWatchCategoryMembership' => true,
+ 'wgUseRCPatrol' => true,
+ ] );
if ( isset( $wgGroupPermissions['patrollers'] ) ) {
$this->oldPatrollersGroup =
$wgGroupPermissions['patrollers'];
diff --git a/tests/phpunit/includes/specialpage/ChangesListSpecialPageTest.php
b/tests/phpunit/includes/specialpage/ChangesListSpecialPageTest.php
index f494785..fd7e0f1 100644
--- a/tests/phpunit/includes/specialpage/ChangesListSpecialPageTest.php
+++ b/tests/phpunit/includes/specialpage/ChangesListSpecialPageTest.php
@@ -293,6 +293,7 @@
}
public function testRcHidepatrolledDisabledFilter() {
+ $this->setMwGlobals( 'wgUseRCPatrol', false );
$user = $this->getTestUser()->getUser();
$this->assertConditions(
[ # expected
@@ -306,6 +307,7 @@
}
public function testRcHideunpatrolledDisabledFilter() {
+ $this->setMwGlobals( 'wgUseRCPatrol', false );
$user = $this->getTestUser()->getUser();
$this->assertConditions(
[ # expected
--
To view, visit https://gerrit.wikimedia.org/r/379296
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I18965d33171137ff182800512c8c0e8e63de124e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
