Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379340 )
Change subject: Fix warning in DifferenceEngine ...................................................................... Fix warning in DifferenceEngine Make sure that the ar_namespace and ar_text fields are selected from the database. Change-Id: Ic2e8f99f43025510c14e0a8ff2b708b378cf7ef3 (cherry picked from commit 7a44c515808307150ea57c5f007ba48677132c47) --- M includes/diff/DifferenceEngine.php 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/40/379340/1 diff --git a/includes/diff/DifferenceEngine.php b/includes/diff/DifferenceEngine.php index ed8cbb4..a9d6ad6 100644 --- a/includes/diff/DifferenceEngine.php +++ b/includes/diff/DifferenceEngine.php @@ -182,7 +182,10 @@ if ( $this->getUser()->isAllowed( 'deletedhistory' ) ) { $dbr = wfGetDB( DB_REPLICA ); $row = $dbr->selectRow( 'archive', - Revision::selectArchiveFields(), + array_merge( + Revision::selectArchiveFields(), + [ 'ar_namespace', 'ar_title' ] + ), [ 'ar_rev_id' => $id ], __METHOD__ ); if ( $row ) { -- To view, visit https://gerrit.wikimedia.org/r/379340 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic2e8f99f43025510c14e0a8ff2b708b378cf7ef3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: REL1_30 Gerrit-Owner: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: Anomie <bjor...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits