Andrew Bogott has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379700 )
Change subject: dnsleaks.py: use case-insensitive comparisons
......................................................................
dnsleaks.py: use case-insensitive comparisons
We have some Capitalized instances, and Horizon seems
to permit CamelCase names. To stay on the safe side,
don't discard records that differ only by case.
Change-Id: I3e93d5fa1fd8e6a546693034f7c01b3821e4d712
---
M modules/openstack2/files/liberty/admin_scripts/novastats/dnsleaks.py
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/00/379700/1
diff --git
a/modules/openstack2/files/liberty/admin_scripts/novastats/dnsleaks.py
b/modules/openstack2/files/liberty/admin_scripts/novastats/dnsleaks.py
index 9c43bac..1e002de 100755
--- a/modules/openstack2/files/liberty/admin_scripts/novastats/dnsleaks.py
+++ b/modules/openstack2/files/liberty/admin_scripts/novastats/dnsleaks.py
@@ -100,13 +100,13 @@
# we need a fresh copy of all instances so we don't accidentally
# delete things that have been created since we last checked.
instances = clients.allinstances()
- all_nova_instances = ["%s.%s.eqiad.wmflabs." % (instance.name,
instance.tenant_id)
+ all_nova_instances = ["%s.%s.eqiad.wmflabs." % (instance.name.lower(),
instance.tenant_id)
for instance in instances]
- all_nova_shortname_instances = ["%s.eqiad.wmflabs." % (instance.name)
+ all_nova_shortname_instances = ["%s.eqiad.wmflabs." %
(instance.name.lower())
for instance in instances]
for recordset in recordsets:
- name = recordset['name']
+ name = recordset['name'].lower()
if name.endswith(".svc.eqiad.wmflabs."):
# These are service records and shouldn't point to instances.
# Leave them be.
--
To view, visit https://gerrit.wikimedia.org/r/379700
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e93d5fa1fd8e6a546693034f7c01b3821e4d712
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott <abog...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
