Volans has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379742 )
Change subject: wmf-auto-reimage: bugfix variable reference
......................................................................
wmf-auto-reimage: bugfix variable reference
Change-Id: I96a4783a3c52ab841e9e5887ebc84161942739a8
---
M modules/profile/files/cumin/wmf_auto_reimage_host.py
M modules/profile/files/cumin/wmf_auto_reimage_lib.py
2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/42/379742/1
diff --git a/modules/profile/files/cumin/wmf_auto_reimage_host.py
b/modules/profile/files/cumin/wmf_auto_reimage_host.py
index 0052c8b..93928be 100644
--- a/modules/profile/files/cumin/wmf_auto_reimage_host.py
+++ b/modules/profile/files/cumin/wmf_auto_reimage_host.py
@@ -71,6 +71,8 @@
user -- the user that launched the script, for auditing purposes
log_path -- the path of the logfile
"""
+ previous = None
+
# Validate hosts have a signed Puppet certificate
if not args.new and not args.no_verify:
lib.validate_hosts([args.host], args.no_verify)
diff --git a/modules/profile/files/cumin/wmf_auto_reimage_lib.py
b/modules/profile/files/cumin/wmf_auto_reimage_lib.py
index d207ec6..c4f39d5 100644
--- a/modules/profile/files/cumin/wmf_auto_reimage_lib.py
+++ b/modules/profile/files/cumin/wmf_auto_reimage_lib.py
@@ -792,6 +792,10 @@
Arguments:
previous -- a dictionary with state: [list of tags dictionaries] for each
state
"""
+ if previous is None:
+ print_line('Unable to provide conftool repool command, previous state
is unknown')
+ return
+
base_command = "sudo -i confctl select '{tags}' set/pooled={state}"
commands = []
--
To view, visit https://gerrit.wikimedia.org/r/379742
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I96a4783a3c52ab841e9e5887ebc84161942739a8
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Volans <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
