jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/379812 )
Change subject: Perf: Don't include 2 versions of history
......................................................................
Perf: Don't include 2 versions of history
Because the vendor chunk included 'history' but the index file imported
'history/createBrowserHistory' 2 versions of the same library are
included.
Correct the vendor declaration to specify the same library included in
the index entry point.
dist/public/index.*.js then goes down from 32K to 17.5K
Change-Id: I3d76e996bd5298452fd849a3b3d39b5965456a02
---
M webpack.config.ts
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Niedzielski: Looks good to me, approved
jenkins-bot: Verified
diff --git a/webpack.config.ts b/webpack.config.ts
index b5e0d22..dcbe530 100644
--- a/webpack.config.ts
+++ b/webpack.config.ts
@@ -64,7 +64,12 @@
// Client package dependencies (these should be a subset of package.json's
// `dependencies`). This chunk changes when one of the specified
// dependencies changes.
- vendor: ["history", "isomorphic-unfetch", "path-to-regexp", PREACT]
+ vendor: [
+ "history/createBrowserHistory",
+ "isomorphic-unfetch",
+ "path-to-regexp",
+ PREACT
+ ]
},
stats: STATS,
--
To view, visit https://gerrit.wikimedia.org/r/379812
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d76e996bd5298452fd849a3b3d39b5965456a02
Gerrit-PatchSet: 1
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Jhernandez <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
