VolkerE has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379937 )
Change subject: Apex theme: Simplify Radio- & Checkbox*optionWidget label rules
......................................................................
Apex theme: Simplify Radio- & Checkbox*optionWidget label rules
Simplify RadioOptionWidget and CheckboxMultioptionWidget label's
vertical spacing rules, also introducing new LESS variable and
cleanup leftover not applied or duplicated selectors & properties.
Change-Id: Ic369814c69a75912a9ef10c558fca976711bf9bd
---
M src/themes/apex/common.less
M src/themes/apex/widgets.less
2 files changed, 12 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/37/379937/1
diff --git a/src/themes/apex/common.less b/src/themes/apex/common.less
index 6886fbc..79affd4 100644
--- a/src/themes/apex/common.less
+++ b/src/themes/apex/common.less
@@ -54,6 +54,7 @@
@padding-horizontal-base: unit( 10 / 16 / 0.8, em );
@padding-horizontal-frameless: unit( 4 / 16 / 0.8, em );
@padding-vertical-frameless: unit( 4 / 16 / 0.8, em );
+@padding-vertical-label: @padding-vertical-frameless;
@padding-top-textinput: unit( 7 / 16 / 0.8, em );
@padding-bottom-textinput: unit( 8 / 16 / 0.8, em );
diff --git a/src/themes/apex/widgets.less b/src/themes/apex/widgets.less
index ea8f67a..c0849e6 100644
--- a/src/themes/apex/widgets.less
+++ b/src/themes/apex/widgets.less
@@ -149,7 +149,7 @@
.theme-oo-ui-checkboxInputWidget () {}
.theme-oo-ui-checkboxMultioptionWidget () {
- padding: 0;
+ padding: @padding-vertical-label 0;
&.oo-ui-labelElement .oo-ui-labelElement-label {
padding-left: 0.5em;
@@ -165,6 +165,10 @@
.theme-oo-ui-checkboxMultiselectInputWidget () {
.oo-ui-fieldLayout {
margin-bottom: 0;
+
+ .oo-ui-fieldLayout-body {
+ padding: @padding-vertical-label 0;
+ }
}
}
@@ -590,7 +594,6 @@
}
.theme-oo-ui-optionWidget () {
- padding: 0.25em 0.5em;
border: 0;
&-highlighted {
@@ -865,12 +868,9 @@
.theme-oo-ui-radioInputWidget () {}
.theme-oo-ui-radioOptionWidget () {
- padding: 0;
- background-color: transparent;
+ padding: @padding-vertical-label 0;
- &.oo-ui-optionWidget-selected,
- &.oo-ui-optionWidget-pressed,
- &.oo-ui-optionWidget-highlighted {
+ &.oo-ui-optionWidget-selected {
background-color: transparent;
}
@@ -888,6 +888,10 @@
.theme-oo-ui-radioSelectInputWidget () {
.oo-ui-fieldLayout {
margin-bottom: 0;
+
+ .oo-ui-fieldLayout-body {
+ padding: @padding-vertical-label 0;
+ }
}
}
--
To view, visit https://gerrit.wikimedia.org/r/379937
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic369814c69a75912a9ef10c558fca976711bf9bd
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
