jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/380651 )
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 13.0.0
......................................................................
build: Updating mediawiki/mediawiki-codesniffer to 13.0.0
Change-Id: I62f4bd6d3d4d0059b701ab5078bfb193c16d84a8
---
M composer.json
M src/Exceptions/SourceUrlException.php
M src/Html/WikiTextEditor.php
M src/Remote/MediaWiki/RemoteApiImportTitleChecker.php
M src/Services/DuplicateFileRevisionChecker.php
M src/Services/Importer.php
M src/Services/WikiRevisionFactory.php
M src/SpecialImportFile.php
M tests/phan/config.php
9 files changed, 1 insertion(+), 12 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/composer.json b/composer.json
index 6d8c82e..c5ef5fc 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
{
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
- "mediawiki/mediawiki-codesniffer": "0.12.0",
+ "mediawiki/mediawiki-codesniffer": "13.0.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/src/Exceptions/SourceUrlException.php
b/src/Exceptions/SourceUrlException.php
index 1c10f88..c248c2d 100644
--- a/src/Exceptions/SourceUrlException.php
+++ b/src/Exceptions/SourceUrlException.php
@@ -2,8 +2,6 @@
namespace FileImporter\Exceptions;
-use RuntimeException;
-
/**
* Thrown in cases that the SourceUrl is not deemed to be acceptable.
*/
diff --git a/src/Html/WikiTextEditor.php b/src/Html/WikiTextEditor.php
index b36339a..3353610 100644
--- a/src/Html/WikiTextEditor.php
+++ b/src/Html/WikiTextEditor.php
@@ -5,7 +5,6 @@
use EditPage;
use Html;
use SpecialPage;
-use StringUtils;
class WikiTextEditor {
diff --git a/src/Remote/MediaWiki/RemoteApiImportTitleChecker.php
b/src/Remote/MediaWiki/RemoteApiImportTitleChecker.php
index 3da4012..9a6a047 100644
--- a/src/Remote/MediaWiki/RemoteApiImportTitleChecker.php
+++ b/src/Remote/MediaWiki/RemoteApiImportTitleChecker.php
@@ -6,7 +6,6 @@
use FileImporter\Exceptions\HttpRequestException;
use FileImporter\Exceptions\ImportException;
use FileImporter\Interfaces\ImportTitleChecker;
-use FileImporter\Remote\MediaWiki\HttpApiLookup;
use FileImporter\Services\Http\HttpRequestExecutor;
class RemoteApiImportTitleChecker implements ImportTitleChecker {
diff --git a/src/Services/DuplicateFileRevisionChecker.php
b/src/Services/DuplicateFileRevisionChecker.php
index 12ce292..9dc2de7 100644
--- a/src/Services/DuplicateFileRevisionChecker.php
+++ b/src/Services/DuplicateFileRevisionChecker.php
@@ -5,7 +5,6 @@
use File;
use FileImporter\Data\FileRevision;
use LocalRepo;
-use Wikimedia\Assert\Assert;
/**
* Class that can be used to check if a FileRevision already exists on the
current wiki.
diff --git a/src/Services/Importer.php b/src/Services/Importer.php
index c697504..4308c9e 100644
--- a/src/Services/Importer.php
+++ b/src/Services/Importer.php
@@ -12,7 +12,6 @@
use Psr\Log\LoggerAwareInterface;
use Psr\Log\LoggerInterface;
use Psr\Log\NullLogger;
-use Revision;
use RuntimeException;
use Title;
use User;
diff --git a/src/Services/WikiRevisionFactory.php
b/src/Services/WikiRevisionFactory.php
index ae732e9..9844b4b 100644
--- a/src/Services/WikiRevisionFactory.php
+++ b/src/Services/WikiRevisionFactory.php
@@ -5,7 +5,6 @@
use Config;
use FileImporter\Data\FileRevision;
use FileImporter\Data\TextRevision;
-use InvalidArgumentException;
use Title;
use WikiRevision;
diff --git a/src/SpecialImportFile.php b/src/SpecialImportFile.php
index 5da354b..7693731 100644
--- a/src/SpecialImportFile.php
+++ b/src/SpecialImportFile.php
@@ -17,7 +17,6 @@
use FileImporter\Html\ImportSuccessPage;
use FileImporter\Html\InputFormPage;
use FileImporter\Html\RecoverableTitleExceptionPage;
-use FileImporter\Services\DuplicateFileRevisionChecker;
use FileImporter\Services\Importer;
use FileImporter\Services\ImportPlanFactory;
use FileImporter\Services\SourceSiteLocator;
@@ -27,7 +26,6 @@
use Message;
use PermissionsError;
use SpecialPage;
-use StringUtils;
use UploadBase;
use User;
use UserBlockedError;
diff --git a/tests/phan/config.php b/tests/phan/config.php
index 5d61e6d..7872155 100644
--- a/tests/phan/config.php
+++ b/tests/phan/config.php
@@ -1,7 +1,5 @@
<?php
-use \Phan\Config;
-
// If xdebug is enabled, we need to increase the nesting level for phan
ini_set( 'xdebug.max_nesting_level', 1000 );
--
To view, visit https://gerrit.wikimedia.org/r/380651
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I62f4bd6d3d4d0059b701ab5078bfb193c16d84a8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FileImporter
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Andrew-WMDE <andrew.kos...@wikimedia.de>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: WMDE-Fisch <christoph.jau...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
