jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/379723 )
Change subject: Fix toolbar initialization (fixes tool width)
......................................................................
Fix toolbar initialization (fixes tool width)
* Initialize toolbar after setup
* Don't initialize actions toolbar
Change-Id: I7ab2cb29220efad8c6404595871f56b9e6f675f3
---
M modules/ui/mw.cx.ui.TranslationView.js
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
Objections:
Nikerabbit: There's a problem with this change, please improve
diff --git a/modules/ui/mw.cx.ui.TranslationView.js
b/modules/ui/mw.cx.ui.TranslationView.js
index 4317e7c..fad6cb4 100644
--- a/modules/ui/mw.cx.ui.TranslationView.js
+++ b/modules/ui/mw.cx.ui.TranslationView.js
@@ -131,6 +131,7 @@
this.publishButton = publishButton;
this.publishSettings = publishSettings;
this.getToolbar().$actions.append( this.publishSettings.$element,
this.publishButton.$element );
+ this.getToolbar().initialize();
};
mw.cx.ui.TranslationView.prototype.unbindHandlers = function () {
@@ -253,10 +254,7 @@
};
mw.cx.ui.TranslationView.prototype.attachToolbar = function () {
- var toolbar = this.getToolbar();
- this.header.$toolbar.append( toolbar.$element );
- toolbar.initialize();
- this.getActions().initialize();
+ this.header.$toolbar.append( this.getToolbar().$element );
};
mw.cx.ui.TranslationView.prototype.onDocumentTransact = function () {
--
To view, visit https://gerrit.wikimedia.org/r/379723
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ab2cb29220efad8c6404595871f56b9e6f675f3
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Catrope <r...@wikimedia.org>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: Santhosh <santhosh.thottin...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
