Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381071 )
Change subject: Revision::newFromTitle may return null ...................................................................... Revision::newFromTitle may return null Bug: T176882 Change-Id: I9aea25c2db81a12f16414edcb279f3241dc380bc --- M includes/skins/SkinMinerva.php 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue refs/changes/71/381071/1 diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php index cc09b05..102bef4 100644 --- a/includes/skins/SkinMinerva.php +++ b/includes/skins/SkinMinerva.php @@ -746,7 +746,12 @@ $historyUrl = $title->getLocalURL( [ 'action' => 'history' ] ); } - $editor = $this->getRevisionEditor( Revision::newFromTitle( $title ) ); + $rev = Revision::newFromTitle( $title ); + if ( $rev ) { + $editor = $this->getRevisionEditor( $rev ); + } else { + $editor = false; + } return [ // Use $edit['timestamp'] (Unix format) instead of $timestamp (MW format) 'data-timestamp' => $isMainPage ? '' : wfTimestamp( TS_UNIX, $timestamp ), -- To view, visit https://gerrit.wikimedia.org/r/381071 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9aea25c2db81a12f16414edcb279f3241dc380bc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/skins/MinervaNeue Gerrit-Branch: master Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits