Aude has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/381371 )

Change subject: Stop using $wgWikibaseSharedCacheKeyPrefix from Wikidata build
......................................................................

Stop using $wgWikibaseSharedCacheKeyPrefix from Wikidata build

we can instead incorporate $wmgVersionNumber into the cache key name

Bug: T176948
Change-Id: Iffede42941d1ec4823f7b84e73347315000a4408
---
M wmf-config/Wikibase.php
1 file changed, 3 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/71/381371/1

diff --git a/wmf-config/Wikibase.php b/wmf-config/Wikibase.php
index 4631797..e7bc8db 100644
--- a/wmf-config/Wikibase.php
+++ b/wmf-config/Wikibase.php
@@ -2,11 +2,9 @@
 
 require_once "$IP/extensions/Wikidata/Wikidata.php";
 
-// The version number now comes from the Wikidata build,
-// included above, so that cache invalidations can be in sync
-// extension changes when there is a new extension branch or
-// otherwise needed to change the cache key.
-$wgWBSharedCacheKey = '-' . $wmgWikibaseCachePrefix;
+// This allows cache invalidations to be in sync with deploys
+// and not shared across different versions of wikibase.
+$wgWBSharedCacheKey = '-wikibase_shared/wikidata_' . $wmgVersionNumber;
 
 if ( defined( 'HHVM_VERSION' ) ) {
        // Split the cache up for hhvm. T73461

-- 
To view, visit https://gerrit.wikimedia.org/r/381371
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iffede42941d1ec4823f7b84e73347315000a4408
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to