Gehel has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381749 )
Change subject: disabled a few spotbugs rules
......................................................................
disabled a few spotbugs rules
Change-Id: I1b549ccfa7ecca4ba9a4f2ec4d3c1cb108ecad92
---
M
src/main/resources/org/wikimedia/discovery/build/tools/spotbugs/spotbugs-excludes.xml
1 file changed, 7 insertions(+), 3 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/wikimedia/discovery/discovery-maven-tool-configs
refs/changes/49/381749/1
diff --git
a/src/main/resources/org/wikimedia/discovery/build/tools/spotbugs/spotbugs-excludes.xml
b/src/main/resources/org/wikimedia/discovery/build/tools/spotbugs/spotbugs-excludes.xml
index 3039b90..15e4e8c 100644
---
a/src/main/resources/org/wikimedia/discovery/build/tools/spotbugs/spotbugs-excludes.xml
+++
b/src/main/resources/org/wikimedia/discovery/build/tools/spotbugs/spotbugs-excludes.xml
@@ -26,10 +26,14 @@
<Bug pattern="LSC_LITERAL_STRING_COMPARISON"/>
</Match>
- <!-- specific exceptions -->
- <Match
classregex="org\.wikimedia\.search\.extra\.regex\.SourceRegexQueryBuilder.*">
- <!-- In this case, an array is accessed with known locations in array
-->
+ <Match>
+ <!-- We have only seen false positives with this rule, so let's ignore
it. -->
<Bug pattern="CLI_CONSTANT_LIST_INDEX"/>
</Match>
+ <Match>
+ <!-- Semantic isn't that confusing. -->
+ <Bug pattern="CFS_CONFUSING_FUNCTION_SEMANTICS" />
+ </Match>
+
</FindBugsFilter>
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/381749
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b549ccfa7ecca4ba9a4f2ec4d3c1cb108ecad92
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/discovery/discovery-maven-tool-configs
Gerrit-Branch: master
Gerrit-Owner: Gehel <guillaume.leder...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
