Jforrester has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381878 )
Change subject: DesktopArticleTarget: Retain 'mwTarget' stats tracking object
......................................................................
DesktopArticleTarget: Retain 'mwTarget' stats tracking object
Bug: T177250
Change-Id: I1584f452e16272886af459bac3e24c4995af2231
(cherry picked from commit 09cde07c452ea23d1e91533fca8038f2cfb7f948)
---
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/78/381878/1
diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
index 89a8038..8b1f761 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
@@ -249,7 +249,10 @@
return
mw.libs.ve.targetLoader.requestPageData( mode, mw.config.get(
'wgRelevantPageName' ), {
section: section,
oldId: oldId,
- targetName: 'article', //
ve.init.mw.DesktopArticleTarget.static.name
+ // Should be
ve.init.mw.DesktopArticleTarget.static.trackingName, but the
+ // class hasn't loaded yet.
+ // This is used for stats
tracking, so do not change!
+ targetName: 'mwTarget',
modified: modified,
preload: uri.query.preload,
preloadparams: uri.query[
'preloadparams[]' ],
--
To view, visit https://gerrit.wikimedia.org/r/381878
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1584f452e16272886af459bac3e24c4995af2231
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: wmf/1.31.0-wmf.1
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
