Zfilipin has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381948 )
Change subject: Selenium tests should log in before creating pages
......................................................................
Selenium tests should log in before creating pages
MediaWiki Vagrant by default allows creating pages to anonymous users, but
other environments, like Beta Cluster, require user to log in before creating
pages.
Bug: T176315
Change-Id: I34eeaf3cc22a64be6580aa483b28885137ba60b6
---
M tests/selenium/pageobjects/edit.page.js
M tests/selenium/wdio.conf.jenkins.js
2 files changed, 17 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/48/381948/1
diff --git a/tests/selenium/pageobjects/edit.page.js
b/tests/selenium/pageobjects/edit.page.js
index 25da8cb..1b86926 100644
--- a/tests/selenium/pageobjects/edit.page.js
+++ b/tests/selenium/pageobjects/edit.page.js
@@ -27,15 +27,23 @@
server: baseUrl.hostname,
port: baseUrl.port,
path: baseUrl.path,
+ username: browser.options.username,
+ password: browser.options.password,
debug: false
} );
return new Promise( ( resolve, reject ) => {
- client.edit( name, content, `Created page with
"${content}"`, function ( err ) {
+ client.logIn( function ( err ) {
if ( err ) {
- return reject( err );
+ console.log( err );
+ return;
}
- resolve();
+ client.edit( name, content, `Created page with
"${content}"`, function ( err ) {
+ if ( err ) {
+ return reject( err );
+ }
+ resolve();
+ } );
} );
} );
}
diff --git a/tests/selenium/wdio.conf.jenkins.js
b/tests/selenium/wdio.conf.jenkins.js
index 6049eb2..cbec7a4 100644
--- a/tests/selenium/wdio.conf.jenkins.js
+++ b/tests/selenium/wdio.conf.jenkins.js
@@ -6,8 +6,12 @@
// Overwrite default settings
exports.config = merge( wdioConf.config, {
- username: 'WikiAdmin',
- password: 'testpass',
+ username: process.env.MEDIAWIKI_USER === undefined ?
+ 'WikiAdmin' :
+ process.env.MEDIAWIKI_USER,
+ password: process.env.MEDIAWIKI_PASSWORD === undefined ?
+ 'testpass' :
+ process.env.MEDIAWIKI_PASSWORD,
screenshotPath: '../log/',
baseUrl: process.env.MW_SERVER + process.env.MW_SCRIPT_PATH,
--
To view, visit https://gerrit.wikimedia.org/r/381948
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I34eeaf3cc22a64be6580aa483b28885137ba60b6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
