jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/382085 )
Change subject: Remove mentions of StubObject, just for typehinting
......................................................................
Remove mentions of StubObject, just for typehinting
StubObject & friends just simply aren't in style these days. They're
not Agile.
Change-Id: If19f1a8559ac9a9a6d8debfb16fe53288803d523
---
M includes/Import/Wikitext/ConversionStrategy.php
M includes/Import/Wikitext/ImportSource.php
2 files changed, 3 insertions(+), 5 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Import/Wikitext/ConversionStrategy.php
b/includes/Import/Wikitext/ConversionStrategy.php
index 76719e3..70bc7f9 100644
--- a/includes/Import/Wikitext/ConversionStrategy.php
+++ b/includes/Import/Wikitext/ConversionStrategy.php
@@ -10,7 +10,6 @@
use LinkBatch;
use Parser;
use Psr\Log\LoggerInterface;
-use StubObject;
use Title;
use User;
use WikitextContent;
@@ -41,7 +40,7 @@
protected $sourceStore;
/**
- * @var Parser|StubObject
+ * @var Parser
*/
protected $parser;
@@ -63,7 +62,7 @@
protected $user;
/**
- * @param Parser|StubObject $parser
+ * @param Parser $parser
* @param ImportSourceStore $sourceStore
* @param LoggerInterface $logger
* @param User $user User to take conversion actions are (applicable
for actions
diff --git a/includes/Import/Wikitext/ImportSource.php
b/includes/Import/Wikitext/ImportSource.php
index 7b3d75e..b6ad14a 100644
--- a/includes/Import/Wikitext/ImportSource.php
+++ b/includes/Import/Wikitext/ImportSource.php
@@ -12,7 +12,6 @@
use Parser;
use ParserOptions;
use Revision;
-use StubObject;
use Title;
use User;
@@ -30,7 +29,7 @@
/**
* @param Title $title
- * @param Parser|StubObject $parser
+ * @param Parser $parser
* @param User $user User to take actions as
* @param string $headerSuffix
* @throws ImportException When $title is an external title
--
To view, visit https://gerrit.wikimedia.org/r/382085
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If19f1a8559ac9a9a6d8debfb16fe53288803d523
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: MaxSem <maxsem.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
