jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/382090 )
Change subject: PopupToolGroup: Move accelerator keys `padding` to themes
......................................................................
PopupToolGroup: Move accelerator keys `padding` to themes
Moving accelerator keys `padding` rule to themes and slightly minimize
in WikimediaUI theme.
Change-Id: I7967180f974a33a66a2bf2d87ef9d0b8363008b5
---
M src/styles/toolgroups/PopupToolGroup.less
M src/themes/apex/tools.less
M src/themes/wikimediaui/tools.less
3 files changed, 11 insertions(+), 5 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/src/styles/toolgroups/PopupToolGroup.less
b/src/styles/toolgroups/PopupToolGroup.less
index 0cd6563..50b094e 100644
--- a/src/styles/toolgroups/PopupToolGroup.less
+++ b/src/styles/toolgroups/PopupToolGroup.less
@@ -56,11 +56,6 @@
.oo-ui-tool-accel {
text-align: right;
}
-
- .oo-ui-tool-accel:not( :empty ) {
- // Push away from tool's title
- padding-left: 3em;
- }
}
.theme-oo-ui-popupToolGroup();
diff --git a/src/themes/apex/tools.less b/src/themes/apex/tools.less
index c61581b..312165b 100644
--- a/src/themes/apex/tools.less
+++ b/src/themes/apex/tools.less
@@ -507,6 +507,12 @@
.oo-ui-tool-accel {
color: @color-base--subtle;
+
+ &:not( :empty ) {
+ // Push away from tool's title
+ padding-left: 3em;
+ }
}
+
}
}
diff --git a/src/themes/wikimediaui/tools.less
b/src/themes/wikimediaui/tools.less
index 980a941..13ba4bd 100644
--- a/src/themes/wikimediaui/tools.less
+++ b/src/themes/wikimediaui/tools.less
@@ -378,6 +378,11 @@
.oo-ui-tool-accel {
color: @color-base--subtle;
line-height: @line-height-widget-singleline;
+
+ &:not( :empty ) {
+ // Push away from tool's title
+ padding-left: @padding-horizontal-base * 1.5;
+ }
}
}
--
To view, visit https://gerrit.wikimedia.org/r/382090
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7967180f974a33a66a2bf2d87ef9d0b8363008b5
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
