jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/382077 )
Change subject: WikimediaUI theme: Fix flagged elements' icon `opacity`
......................................................................
WikimediaUI theme: Fix flagged elements' icon `opacity`
Flagged elements' icon `opacity` should remain `1` to be
aligned to label color.
Change-Id: Idd650b52ebe4ff8f322c2b0935542b9e875542df
---
M src/themes/wikimediaui/tools.less
1 file changed, 23 insertions(+), 8 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/src/themes/wikimediaui/tools.less
b/src/themes/wikimediaui/tools.less
index b0ddfff..8791af1 100644
--- a/src/themes/wikimediaui/tools.less
+++ b/src/themes/wikimediaui/tools.less
@@ -120,6 +120,12 @@
opacity: @opacity-base;
}
}
+
+ &[class*='oo-ui-flaggedElement'] {
+ .oo-ui-iconElement-icon {
+ opacity: @opacity-base;
+ }
+ }
}
&.oo-ui-widget-disabled .oo-ui-iconElement-icon {
@@ -388,14 +394,6 @@
box-shadow @transition-ease-quick
);
- // We don't generalize this further, as only
PopupToolGroup carries them,
- // all other ToolGroups own Tools, which come with
their own icon rules
- .oo-ui-iconElement-icon,
- .oo-ui-indicatorElement-indicator {
- opacity: @opacity-icon-base;
- .oo-ui-transition( opacity
@transition-ease-quick );
- }
-
&:hover {
background-color: @background-color-tool--hover;
}
@@ -404,6 +402,14 @@
background-color:
@background-color-tool--active;
}
+ // We don't generalize this further, as only
PopupToolGroup carries them,
+ // all other ToolGroups own Tools, which come with
their own icon rules
+ .oo-ui-iconElement-icon,
+ .oo-ui-indicatorElement-indicator {
+ opacity: @opacity-icon-base;
+ .oo-ui-transition( opacity
@transition-ease-quick );
+ }
+
&:hover,
&:active {
.oo-ui-iconElement-icon,
@@ -412,6 +418,15 @@
}
}
}
+
+ &[class*='oo-ui-flaggedElement'] > .oo-ui-popupToolGroup-handle
{
+ &,
+ &:hover {
+ .oo-ui-iconElement-icon {
+ opacity: @opacity-icon-base--selected;
+ }
+ }
+ }
}
&.oo-ui-popupToolGroup-active {
--
To view, visit https://gerrit.wikimedia.org/r/382077
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd650b52ebe4ff8f322c2b0935542b9e875542df
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
