jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/382095 )
Change subject: Revert "Use Language type hint in hooks" ...................................................................... Revert "Use Language type hint in hooks" This reverts commit d80000572921ee11e0c483b3637f600872b6eb09. Bug: T177352 Change-Id: I3ac248e6e2152b4b3032def56c433b12aceb798c --- M TranslateHooks.php M tag/PageTranslationHooks.php 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Zfilipin: Looks good to me, approved jenkins-bot: Verified Nikerabbit: Looks good to me, but someone else must approve diff --git a/TranslateHooks.php b/TranslateHooks.php index 1a7613f..a6b6a52 100644 --- a/TranslateHooks.php +++ b/TranslateHooks.php @@ -440,7 +440,7 @@ * @param Title $title * @param Language &$pageLang */ - public static function onPageContentLanguage( Title $title, Language &$pageLang ) { + public static function onPageContentLanguage( Title $title, &$pageLang ) { $handle = new MessageHandle( $title ); if ( $handle->isMessageNamespace() ) { $pageLang = $handle->getEffectiveLanguage(); diff --git a/tag/PageTranslationHooks.php b/tag/PageTranslationHooks.php index 614ceae..53f63f1 100644 --- a/tag/PageTranslationHooks.php +++ b/tag/PageTranslationHooks.php @@ -76,7 +76,7 @@ * @param Title $title * @param Language &$pageLang */ - public static function onPageContentLanguage( Title $title, Language &$pageLang ) { + public static function onPageContentLanguage( Title $title, &$pageLang ) { // For translation pages, parse plural, grammar etc with correct language, // and set the right direction if ( TranslatablePage::isTranslationPage( $title ) ) { -- To view, visit https://gerrit.wikimedia.org/r/382095 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ac248e6e2152b4b3032def56c433b12aceb798c Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: wmf/1.31.0-wmf.2 Gerrit-Owner: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com> Gerrit-Reviewer: Zfilipin <zfili...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits