jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/378076 )

Change subject: Turn on native CodeMirror spellcheck feature
......................................................................


Turn on native CodeMirror spellcheck feature

It's not fullproof. There's bugs where it forgets a string is misspelled
after re-rendering. But it's better than nothing.

Bug: T95104
Change-Id: I33718a71ff5734912ac59be2cd9575dd662ec2f7
---
M resources/ext.CodeMirror.js
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Kaldari: Looks good to me, approved

Objections:
  Fomafix: There's a problem with this change, please improve



diff --git a/resources/ext.CodeMirror.js b/resources/ext.CodeMirror.js
index 833fe86..7183450 100644
--- a/resources/ext.CodeMirror.js
+++ b/resources/ext.CodeMirror.js
@@ -376,6 +376,8 @@
                                        Home: 'goLineLeft',
                                        End: 'goLineRight'
                                },
+                               inputStyle: 'contenteditable',
+                               spellcheck: true,
                                viewportMargin: Infinity
                        } );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/378076
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I33718a71ff5734912ac59be2cd9575dd662ec2f7
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/CodeMirror
Gerrit-Branch: master
Gerrit-Owner: Niharika29 <nko...@wikimedia.org>
Gerrit-Reviewer: Fomafix <foma...@googlemail.com>
Gerrit-Reviewer: Kaldari <rkald...@wikimedia.org>
Gerrit-Reviewer: MaxSem <maxsem.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to