Lucas Werkmeister (WMDE) has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/382446 )

Change subject: Add external identifier prop+stmt to RDF tests
......................................................................

Add external identifier prop+stmt to RDF tests

Now that external identifiers get some special treatment in RDF as well
and aren’t functionally equivalent to plain strings, the RDF tests
should definitely cover them separately. (Notably, they have normalized
predicates.)

Bug: T121274
Change-Id: Ia0422b4626b4e24f6bbbb3c285c8478c84c68deb
---
M repo/tests/phpunit/data/rdf/RdfBuilder/Q4_direct.nt
M repo/tests/phpunit/data/rdf/RdfBuilder/Q4_props.nt
M repo/tests/phpunit/data/rdf/RdfBuilder/Q4_statements.nt
M repo/tests/phpunit/data/rdf/RdfBuilder/Q4_values.nt
M repo/tests/phpunit/data/rdf/entities/Q4.json
M repo/tests/phpunit/includes/Rdf/RdfBuilderTestData.php
6 files changed, 67 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/46/382446/1

diff --git a/repo/tests/phpunit/data/rdf/RdfBuilder/Q4_direct.nt 
b/repo/tests/phpunit/data/rdf/RdfBuilder/Q4_direct.nt
index 7ff1ce2..5a07182 100644
--- a/repo/tests/phpunit/data/rdf/RdfBuilder/Q4_direct.nt
+++ b/repo/tests/phpunit/data/rdf/RdfBuilder/Q4_direct.nt
@@ -1,4 +1,5 @@
 <http://acme.test/Q4> <http://acme.test/prop/direct/P10> 
<http://commons.wikimedia.org/data/main/Data:Berlin.map> .
+<http://acme.test/Q4> <http://acme.test/prop/direct/P11> 
"test-external-identifier" .
 <http://acme.test/Q4> <http://acme.test/prop/direct/P2> <http://acme.test/Q42> 
.
 <http://acme.test/Q4> <http://acme.test/prop/direct/P3> 
<http://commons.wikimedia.org/wiki/Special:FilePath/Universe.svg> .
 <http://acme.test/Q4> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://acme.test/prop/novalue/P3> .
diff --git a/repo/tests/phpunit/data/rdf/RdfBuilder/Q4_props.nt 
b/repo/tests/phpunit/data/rdf/RdfBuilder/Q4_props.nt
index c99c5be..a6d3a60 100644
--- a/repo/tests/phpunit/data/rdf/RdfBuilder/Q4_props.nt
+++ b/repo/tests/phpunit/data/rdf/RdfBuilder/Q4_props.nt
@@ -11,6 +11,7 @@
 <http://acme.test/Q4> <http://acme.test/prop/P8> 
<http://acme.test/statement/TEST-Statement-8-5dd0f6624a7545401bc306a068ac1bbe8148bfac>
 .
 <http://acme.test/Q4> <http://acme.test/prop/P9> 
<http://acme.test/statement/TEST-Statement-9-2669d541dfd2d6cc0105927bff02bbe0eec0e921>
 .
 <http://acme.test/Q4> <http://acme.test/prop/P10> 
<http://acme.test/statement/TEST-Statement-10-geo-shape> .
+<http://acme.test/Q4> <http://acme.test/prop/P11> 
<http://acme.test/statement/TEST-Statement-11-external-id> .
 <http://acme.test/Q4> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://wikiba.se/ontology-beta#Item> .
 
<http://acme.test/statement/TEST-Statement-2-423614cd831ed4e8da1138c9229cb65cf96f9366>
 <http://acme.test/prop/statement/P2> <http://acme.test/Q42> .
 
<http://acme.test/statement/TEST-Statement-2-423614cd831ed4e8da1138c9229cb65cf96f9366>
 <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://wikiba.se/ontology-beta#Statement> .
@@ -61,6 +62,10 @@
 <http://acme.test/statement/TEST-Statement-10-geo-shape> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://wikiba.se/ontology-beta#Statement> .
 <http://acme.test/statement/TEST-Statement-10-geo-shape> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://wikiba.se/ontology-beta#BestRank> .
 <http://acme.test/statement/TEST-Statement-10-geo-shape> 
<http://wikiba.se/ontology-beta#rank> 
<http://wikiba.se/ontology-beta#NormalRank> .
+<http://acme.test/statement/TEST-Statement-11-external-id> 
<http://acme.test/prop/statement/P11> "test-external-identifier" .
+<http://acme.test/statement/TEST-Statement-11-external-id> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://wikiba.se/ontology-beta#Statement> .
+<http://acme.test/statement/TEST-Statement-11-external-id> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://wikiba.se/ontology-beta#BestRank> .
+<http://acme.test/statement/TEST-Statement-11-external-id> 
<http://wikiba.se/ontology-beta#rank> 
<http://wikiba.se/ontology-beta#NormalRank> .
 <http://data.acme.test/Q4> <http://schema.org/about> <http://acme.test/Q4> .
 <http://data.acme.test/Q4> <http://schema.org/dateModified> 
"2013-10-04T03:31:05Z"^^<http://www.w3.org/2001/XMLSchema#dateTime> .
 <http://data.acme.test/Q4> <http://schema.org/version> 
"42"^^<http://www.w3.org/2001/XMLSchema#integer> .
@@ -101,6 +106,10 @@
 <http://acme.test/P10> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://wikiba.se/ontology-beta#Property> .
 <http://acme.test/P10> <http://www.w3.org/2000/01/rdf-schema#label> 
"Property10"@en .
 <http://acme.test/P10> <http://www.w3.org/2004/02/skos/core#prefLabel> 
"Property10"@en .
+<http://acme.test/P11> <http://schema.org/name> "Property11"@en .
+<http://acme.test/P11> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://wikiba.se/ontology-beta#Property> .
+<http://acme.test/P11> <http://www.w3.org/2000/01/rdf-schema#label> 
"Property11"@en .
+<http://acme.test/P11> <http://www.w3.org/2004/02/skos/core#prefLabel> 
"Property11"@en .
 <http://acme.test/P2> <http://wikiba.se/ontology-beta#propertyType> 
<http://wikiba.se/ontology-beta#WikibaseItem> .
 <http://acme.test/P3> <http://wikiba.se/ontology-beta#propertyType> 
<http://wikiba.se/ontology-beta#CommonsMedia> .
 <http://acme.test/P4> <http://wikiba.se/ontology-beta#propertyType> 
<http://wikiba.se/ontology-beta#GlobeCoordinate> .
@@ -110,6 +119,7 @@
 <http://acme.test/P8> <http://wikiba.se/ontology-beta#propertyType> 
<http://wikiba.se/ontology-beta#Time> .
 <http://acme.test/P9> <http://wikiba.se/ontology-beta#propertyType> 
<http://wikiba.se/ontology-beta#Url> .
 <http://acme.test/P10> <http://wikiba.se/ontology-beta#propertyType> 
<http://wikiba.se/ontology-beta#GeoShape> .
+<http://acme.test/P11> <http://wikiba.se/ontology-beta#propertyType> 
<http://wikiba.se/ontology-beta#ExternalId> .
 <http://acme.test/P2> <http://wikiba.se/ontology-beta#claim> 
<http://acme.test/prop/P2> .
 <http://acme.test/P2> <http://wikiba.se/ontology-beta#directClaim> 
<http://acme.test/prop/direct/P2> .
 <http://acme.test/P2> <http://wikiba.se/ontology-beta#qualifier> 
<http://acme.test/prop/qualifier/P2> .
@@ -183,6 +193,18 @@
 <http://acme.test/P10> <http://wikiba.se/ontology-beta#referenceValue> 
<http://acme.test/prop/reference/value/P10> .
 <http://acme.test/P10> <http://wikiba.se/ontology-beta#statementProperty> 
<http://acme.test/prop/statement/P10> .
 <http://acme.test/P10> <http://wikiba.se/ontology-beta#statementValue> 
<http://acme.test/prop/statement/value/P10> .
+<http://acme.test/P11> <http://wikiba.se/ontology-beta#claim> 
<http://acme.test/prop/P11> .
+<http://acme.test/P11> <http://wikiba.se/ontology-beta#directClaim> 
<http://acme.test/prop/direct/P11> .
+<http://acme.test/P11> <http://wikiba.se/ontology-beta#directClaimNormalized> 
<http://acme.test/prop/direct-normalized/P11> .
+<http://acme.test/P11> <http://wikiba.se/ontology-beta#qualifier> 
<http://acme.test/prop/qualifier/P11> .
+<http://acme.test/P11> <http://wikiba.se/ontology-beta#qualifierValue> 
<http://acme.test/prop/qualifier/value/P11> .
+<http://acme.test/P11> 
<http://wikiba.se/ontology-beta#qualifierValueNormalized> 
<http://acme.test/prop/qualifier/value-normalized/P11> .
+<http://acme.test/P11> <http://wikiba.se/ontology-beta#reference> 
<http://acme.test/prop/reference/P11> .
+<http://acme.test/P11> <http://wikiba.se/ontology-beta#referenceValue> 
<http://acme.test/prop/reference/value/P11> .
+<http://acme.test/P11> 
<http://wikiba.se/ontology-beta#referenceValueNormalized> 
<http://acme.test/prop/reference/value-normalized/P11> .
+<http://acme.test/P11> <http://wikiba.se/ontology-beta#statementProperty> 
<http://acme.test/prop/statement/P11> .
+<http://acme.test/P11> <http://wikiba.se/ontology-beta#statementValue> 
<http://acme.test/prop/statement/value/P11> .
+<http://acme.test/P11> 
<http://wikiba.se/ontology-beta#statementValueNormalized> 
<http://acme.test/prop/statement/value-normalized/P11> .
 <http://acme.test/P2> <http://wikiba.se/ontology-beta#novalue> 
<http://acme.test/prop/novalue/P2> .
 <http://acme.test/P3> <http://wikiba.se/ontology-beta#novalue> 
<http://acme.test/prop/novalue/P3> .
 <http://acme.test/P4> <http://wikiba.se/ontology-beta#novalue> 
<http://acme.test/prop/novalue/P4> .
@@ -192,6 +214,7 @@
 <http://acme.test/P8> <http://wikiba.se/ontology-beta#novalue> 
<http://acme.test/prop/novalue/P8> .
 <http://acme.test/P9> <http://wikiba.se/ontology-beta#novalue> 
<http://acme.test/prop/novalue/P9> .
 <http://acme.test/P10> <http://wikiba.se/ontology-beta#novalue> 
<http://acme.test/prop/novalue/P10> .
+<http://acme.test/P11> <http://wikiba.se/ontology-beta#novalue> 
<http://acme.test/prop/novalue/P11> .
 <http://acme.test/prop/novalue/P2> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://www.w3.org/2002/07/owl#Class> .
 <http://acme.test/prop/novalue/P2> 
<http://www.w3.org/2002/07/owl#complementOf> _:genid2 .
 <http://acme.test/prop/novalue/P3> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://www.w3.org/2002/07/owl#Class> .
@@ -210,6 +233,8 @@
 <http://acme.test/prop/novalue/P9> 
<http://www.w3.org/2002/07/owl#complementOf> _:genid9 .
 <http://acme.test/prop/novalue/P10> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://www.w3.org/2002/07/owl#Class> .
 <http://acme.test/prop/novalue/P10> 
<http://www.w3.org/2002/07/owl#complementOf> _:genid10 .
+<http://acme.test/prop/novalue/P11> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://www.w3.org/2002/07/owl#Class> .
+<http://acme.test/prop/novalue/P11> 
<http://www.w3.org/2002/07/owl#complementOf> _:genid11 .
 _:genid2 <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://www.w3.org/2002/07/owl#Restriction> .
 _:genid2 <http://www.w3.org/2002/07/owl#onProperty> 
<http://acme.test/prop/direct/P2> .
 _:genid2 <http://www.w3.org/2002/07/owl#someValuesFrom> 
<http://www.w3.org/2002/07/owl#Thing> .
@@ -237,6 +262,9 @@
 _:genid10 <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://www.w3.org/2002/07/owl#Restriction> .
 _:genid10 <http://www.w3.org/2002/07/owl#onProperty> 
<http://acme.test/prop/direct/P10> .
 _:genid10 <http://www.w3.org/2002/07/owl#someValuesFrom> 
<http://www.w3.org/2002/07/owl#Thing> .
+_:genid11 <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://www.w3.org/2002/07/owl#Restriction> .
+_:genid11 <http://www.w3.org/2002/07/owl#onProperty> 
<http://acme.test/prop/direct/P11> .
+_:genid11 <http://www.w3.org/2002/07/owl#someValuesFrom> 
<http://www.w3.org/2002/07/owl#Thing> .
 <http://acme.test/prop/P2> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://www.w3.org/2002/07/owl#ObjectProperty> .
 <http://acme.test/prop/direct/P2> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://www.w3.org/2002/07/owl#ObjectProperty> .
 <http://acme.test/prop/qualifier/P2> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://www.w3.org/2002/07/owl#ObjectProperty> .
@@ -310,6 +338,18 @@
 <http://acme.test/prop/reference/value/P10> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://www.w3.org/2002/07/owl#ObjectProperty> .
 <http://acme.test/prop/statement/P10> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://www.w3.org/2002/07/owl#ObjectProperty> .
 <http://acme.test/prop/statement/value/P10> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://www.w3.org/2002/07/owl#ObjectProperty> .
+<http://acme.test/prop/P11> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://www.w3.org/2002/07/owl#ObjectProperty> .
+<http://acme.test/prop/direct/P11> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://www.w3.org/2002/07/owl#DatatypeProperty> .
+<http://acme.test/prop/direct-normalized/P11> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://www.w3.org/2002/07/owl#ObjectProperty> .
+<http://acme.test/prop/qualifier/P11> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://www.w3.org/2002/07/owl#DatatypeProperty> .
+<http://acme.test/prop/qualifier/value/P11> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://www.w3.org/2002/07/owl#ObjectProperty> .
+<http://acme.test/prop/qualifier/value-normalized/P11> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://www.w3.org/2002/07/owl#ObjectProperty> .
+<http://acme.test/prop/reference/P11> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://www.w3.org/2002/07/owl#DatatypeProperty> .
+<http://acme.test/prop/reference/value/P11> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://www.w3.org/2002/07/owl#ObjectProperty> .
+<http://acme.test/prop/reference/value-normalized/P11> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://www.w3.org/2002/07/owl#ObjectProperty> .
+<http://acme.test/prop/statement/P11> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://www.w3.org/2002/07/owl#DatatypeProperty> .
+<http://acme.test/prop/statement/value/P11> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://www.w3.org/2002/07/owl#ObjectProperty> .
+<http://acme.test/prop/statement/value-normalized/P11> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://www.w3.org/2002/07/owl#ObjectProperty> .
 <http://acme.test/P6> 
<http://wikiba.se/ontology-beta#statementValueNormalized> 
<http://acme.test/prop/statement/value-normalized/P6> .
 <http://acme.test/P6> 
<http://wikiba.se/ontology-beta#referenceValueNormalized> 
<http://acme.test/prop/reference/value-normalized/P6> .
 <http://acme.test/P6> 
<http://wikiba.se/ontology-beta#qualifierValueNormalized> 
<http://acme.test/prop/qualifier/value-normalized/P6> .
diff --git a/repo/tests/phpunit/data/rdf/RdfBuilder/Q4_statements.nt 
b/repo/tests/phpunit/data/rdf/RdfBuilder/Q4_statements.nt
index eb9818e..34fe602 100644
--- a/repo/tests/phpunit/data/rdf/RdfBuilder/Q4_statements.nt
+++ b/repo/tests/phpunit/data/rdf/RdfBuilder/Q4_statements.nt
@@ -11,6 +11,7 @@
 <http://acme.test/Q4> <http://acme.test/prop/P8> 
<http://acme.test/statement/TEST-Statement-8-5dd0f6624a7545401bc306a068ac1bbe8148bfac>
 .
 <http://acme.test/Q4> <http://acme.test/prop/P9> 
<http://acme.test/statement/TEST-Statement-9-2669d541dfd2d6cc0105927bff02bbe0eec0e921>
 .
 <http://acme.test/Q4> <http://acme.test/prop/P10> 
<http://acme.test/statement/TEST-Statement-10-geo-shape> .
+<http://acme.test/Q4> <http://acme.test/prop/P11> 
<http://acme.test/statement/TEST-Statement-11-external-id> .
 <http://acme.test/statement/TEST-Statement-10-geo-shape> 
<http://acme.test/prop/statement/P10> 
<http://commons.wikimedia.org/data/main/Data:Berlin.map> .
 
<http://acme.test/statement/TEST-Statement-2-423614cd831ed4e8da1138c9229cb65cf96f9366>
 <http://acme.test/prop/statement/P2> <http://acme.test/Q42> .
 
<http://acme.test/statement/TEST-Statement-2-423614cd831ed4e8da1138c9229cb65cf96f9366>
 <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://wikiba.se/ontology-beta#Statement> .
@@ -61,3 +62,7 @@
 <http://acme.test/statement/TEST-Statement-10-geo-shape> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://wikiba.se/ontology-beta#Statement> .
 <http://acme.test/statement/TEST-Statement-10-geo-shape> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://wikiba.se/ontology-beta#BestRank> .
 <http://acme.test/statement/TEST-Statement-10-geo-shape> 
<http://wikiba.se/ontology-beta#rank> 
<http://wikiba.se/ontology-beta#NormalRank> .
+<http://acme.test/statement/TEST-Statement-11-external-id> 
<http://acme.test/prop/statement/P11> "test-external-identifier" .
+<http://acme.test/statement/TEST-Statement-11-external-id> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://wikiba.se/ontology-beta#Statement> .
+<http://acme.test/statement/TEST-Statement-11-external-id> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://wikiba.se/ontology-beta#BestRank> .
+<http://acme.test/statement/TEST-Statement-11-external-id> 
<http://wikiba.se/ontology-beta#rank> 
<http://wikiba.se/ontology-beta#NormalRank> .
diff --git a/repo/tests/phpunit/data/rdf/RdfBuilder/Q4_values.nt 
b/repo/tests/phpunit/data/rdf/RdfBuilder/Q4_values.nt
index f84c917..91bc0b3 100644
--- a/repo/tests/phpunit/data/rdf/RdfBuilder/Q4_values.nt
+++ b/repo/tests/phpunit/data/rdf/RdfBuilder/Q4_values.nt
@@ -11,6 +11,7 @@
 <http://acme.test/Q4> <http://acme.test/prop/P8> 
<http://acme.test/statement/TEST-Statement-8-5dd0f6624a7545401bc306a068ac1bbe8148bfac>
 .
 <http://acme.test/Q4> <http://acme.test/prop/P9> 
<http://acme.test/statement/TEST-Statement-9-2669d541dfd2d6cc0105927bff02bbe0eec0e921>
 .
 <http://acme.test/Q4> <http://acme.test/prop/P10> 
<http://acme.test/statement/TEST-Statement-10-geo-shape> .
+<http://acme.test/Q4> <http://acme.test/prop/P11> 
<http://acme.test/statement/TEST-Statement-11-external-id> .
 
<http://acme.test/statement/TEST-Statement-2-423614cd831ed4e8da1138c9229cb65cf96f9366>
 <http://acme.test/prop/statement/P2> <http://acme.test/Q42> .
 
<http://acme.test/statement/TEST-Statement-2-423614cd831ed4e8da1138c9229cb65cf96f9366>
 <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://wikiba.se/ontology-beta#Statement> .
 
<http://acme.test/statement/TEST-Statement-2-423614cd831ed4e8da1138c9229cb65cf96f9366>
 <http://wikiba.se/ontology-beta#rank> 
<http://wikiba.se/ontology-beta#PreferredRank> .
@@ -63,6 +64,9 @@
 <http://acme.test/statement/TEST-Statement-10-geo-shape> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://wikiba.se/ontology-beta#Statement> .
 <http://acme.test/statement/TEST-Statement-10-geo-shape> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://wikiba.se/ontology-beta#BestRank> .
 <http://acme.test/statement/TEST-Statement-10-geo-shape> 
<http://wikiba.se/ontology-beta#rank> 
<http://wikiba.se/ontology-beta#NormalRank> .
+<http://acme.test/statement/TEST-Statement-11-external-id> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://wikiba.se/ontology-beta#Statement> .
+<http://acme.test/statement/TEST-Statement-11-external-id> 
<http://www.w3.org/1999/02/22-rdf-syntax-ns#type> 
<http://wikiba.se/ontology-beta#BestRank> .
+<http://acme.test/statement/TEST-Statement-11-external-id> 
<http://wikiba.se/ontology-beta#rank> 
<http://wikiba.se/ontology-beta#NormalRank> .
 <http://acme.test/value/002e39a4a1d30d3dbf7eb63d21d93cfd> 
<http://wikiba.se/ontology-beta#geoGlobe> <http://www.wikidata.org/entity/Q2> .
 <http://acme.test/value/002e39a4a1d30d3dbf7eb63d21d93cfd> 
<http://wikiba.se/ontology-beta#geoLatitude> 
"12.125"^^<http://www.w3.org/2001/XMLSchema#decimal> .
 <http://acme.test/value/002e39a4a1d30d3dbf7eb63d21d93cfd> 
<http://wikiba.se/ontology-beta#geoLongitude> 
"67.25"^^<http://www.w3.org/2001/XMLSchema#decimal> .
diff --git a/repo/tests/phpunit/data/rdf/entities/Q4.json 
b/repo/tests/phpunit/data/rdf/entities/Q4.json
index 0f6f1ef..39d1d75 100644
--- a/repo/tests/phpunit/data/rdf/entities/Q4.json
+++ b/repo/tests/phpunit/data/rdf/entities/Q4.json
@@ -220,6 +220,22 @@
                 "type": "statement",
                 "rank": "normal"
             }
+        ],
+        "P11": [
+            {
+                "id": "TEST-Statement-11-external-id",
+                "mainsnak": {
+                    "snaktype": "value",
+                    "property": "P11",
+                    "datatype": "external-id",
+                    "datavalue": {
+                        "value": "test-external-identifier",
+                        "type": "string"
+                    }
+                },
+                "type": "statement",
+                "rank": "normal"
+            }
         ]
     }
 }
diff --git a/repo/tests/phpunit/includes/Rdf/RdfBuilderTestData.php 
b/repo/tests/phpunit/includes/Rdf/RdfBuilderTestData.php
index efa894a..71bd14e 100644
--- a/repo/tests/phpunit/includes/Rdf/RdfBuilderTestData.php
+++ b/repo/tests/phpunit/includes/Rdf/RdfBuilderTestData.php
@@ -232,6 +232,7 @@
                        [ new PropertyId( 'P8' ), 'time' ],
                        [ new PropertyId( 'P9' ), 'url' ],
                        [ new PropertyId( 'P10' ), 'geo-shape' ],
+                       [ new PropertyId( 'P11' ), 'external-id' ],
                ];
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/382446
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0422b4626b4e24f6bbbb3c285c8478c84c68deb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to