Mforns has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/378896 )
Change subject: Fix errors when testing with py34
......................................................................
Fix errors when testing with py34
Bug: T164409
Change-Id: Ib6a70d777bc672a57b895079902598025df2200b
---
M eventlogging/schema.py
M tests/test_handlers.py
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Mforns: Looks good to me, approved
jenkins-bot: Verified
Zoranzoki21: Looks good to me, but someone else must approve
diff --git a/eventlogging/schema.py b/eventlogging/schema.py
index e2334c2..68f276b 100644
--- a/eventlogging/schema.py
+++ b/eventlogging/schema.py
@@ -319,7 +319,7 @@
"""
Returns a list of schema_uris of all cached schemas.""
"""
- return map(schema_uri_from_scid, get_cached_scids())
+ return list(map(schema_uri_from_scid, get_cached_scids()))
def scid_from_uri(
diff --git a/tests/test_handlers.py b/tests/test_handlers.py
index 44a4913..a793682 100644
--- a/tests/test_handlers.py
+++ b/tests/test_handlers.py
@@ -70,7 +70,7 @@
writer = eventlogging.get_writer(
'sqlite://?batch_size=3&batch_time=100000')
- event = _get_event().next()
+ event = next(_get_event())
writer.send(event)
writer.send(event)
@@ -107,8 +107,8 @@
def mock_holder(mock_store_sql_events):
writer = eventlogging.get_writer(
'sqlite://?batch_size=3&batch_time=100000')
- event_topic1 = _get_event().next()
- event_topic2 = _get_event().next()
+ event_topic1 = next(_get_event())
+ event_topic2 = next(_get_event())
event_topic2['topic'] = 'different_test_topic'
writer.send(event_topic1)
--
To view, visit https://gerrit.wikimedia.org/r/378896
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6a70d777bc672a57b895079902598025df2200b
Gerrit-PatchSet: 2
Gerrit-Project: eventlogging
Gerrit-Branch: master
Gerrit-Owner: Mforns <[email protected]>
Gerrit-Reviewer: Mforns <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>
Gerrit-Reviewer: Zoranzoki21 <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
