jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/382502 )
Change subject: Improve some parameter docs
......................................................................
Improve some parameter docs
Change-Id: I811331155802b6097744938df16f5197d74e2686
---
M Hooks.php
M ThreeDHandler.php
M phpcs.xml
3 files changed, 15 insertions(+), 10 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/Hooks.php b/Hooks.php
index f2816e6..a317e78 100644
--- a/Hooks.php
+++ b/Hooks.php
@@ -21,8 +21,8 @@
class Hooks {
/**
- * @param \OutputPage $out
- * @param \Skin $skin
+ * @param \OutputPage &$out
+ * @param \Skin &$skin
* @return bool
*/
public static function onBeforePageDisplay( &$out, &$skin ) {
diff --git a/ThreeDHandler.php b/ThreeDHandler.php
index 02145ad..47cbdee 100644
--- a/ThreeDHandler.php
+++ b/ThreeDHandler.php
@@ -22,20 +22,24 @@
class ThreeDHandler extends \ImageHandler {
/**
- * @param $file
+ * @param \File $file
* @return bool
*/
public function mustRender( $file ) {
return true;
}
+ /**
+ * @param \File $file
+ * @return bool
+ */
public function isVectorized( $file ) {
return true;
}
/**
* @param \File $image
- * @param array $params
+ * @param array &$params
* @return bool
*/
public function normaliseParams( $image, &$params ) {
@@ -129,6 +133,12 @@
return [ 5120, 2880 ];
}
+ /**
+ * @param string $ext
+ * @param string $mime
+ * @param array|null $params
+ * @return array
+ */
public function getThumbType( $ext, $mime, $params = null ) {
return [ 'png', 'image/png' ];
}
diff --git a/phpcs.xml b/phpcs.xml
index 336d3de..d1b5f11 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -2,13 +2,8 @@
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamName" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
</rule>
<file>.</file>
<arg name="extensions" value="php,php5,inc" />
- <arg name="encoding" value="utf8" />
- <exclude-pattern>vendor</exclude-pattern>
+ <arg name="encoding" value="UTF-8" />
</ruleset>
--
To view, visit https://gerrit.wikimedia.org/r/382502
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I811331155802b6097744938df16f5197d74e2686
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/3D
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
