Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/382930 )

Change subject: pybal: support RunCommand everywhere, not just appservers?
......................................................................

pybal: support RunCommand everywhere, not just appservers?

This is part of removing Ganglia support globally,
so it was found because it's using ganglia_clusters.

This is an open question from me for now, how can we
replace that separation between appserver or not without
Ganglia?

Or, as i am doing here, would it be ok if we simply
add the RunCommand monitor everywhere, regardless of that?

Bug: T177225
Change-Id: I78475d5129258f51f90da8ce42f91d35180bc461
---
M modules/profile/manifests/pybal.pp
1 file changed, 1 insertion(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/30/382930/1

diff --git a/modules/profile/manifests/pybal.pp 
b/modules/profile/manifests/pybal.pp
index 06177c7..e8bb2e0 100644
--- a/modules/profile/manifests/pybal.pp
+++ b/modules/profile/manifests/pybal.pp
@@ -6,7 +6,6 @@
     $conftool_prefix = hiera('conftool_prefix'),
     $config_source = hiera('profile::pybal::config_source'),
     $config_host = hiera('profile::pybal::config_host'),
-    $ganglia_clusters = hiera('ganglia_clusters'),
 ) {
 
     requires_os('debian >= jessie')
@@ -56,8 +55,5 @@
     class { '::pybal::monitoring': }
 
     # Sites with MediaWiki appservers need runcommand
-    if $::site in keys($ganglia_clusters['appserver']['sites']) {
-        class { '::lvs::balancer::runcommand': }
-    }
-
+    class { '::lvs::balancer::runcommand': }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/382930
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I78475d5129258f51f90da8ce42f91d35180bc461
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <dz...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to