Hello jenkins-bot,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/383042
to review the following change.
Change subject: Revert "Replace jquery delegate with jquery on"
......................................................................
Revert "Replace jquery delegate with jquery on"
This reverts commit ee3a65a1ee68c458412f91158910875f3eebbc71.
Change-Id: I91794a8a75a60af9966fcd4f1a6c3e3bd579f7c0
---
M modules/ext.collapsiblevector.collapsibleNav.js
1 file changed, 2 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CollapsibleVector
refs/changes/42/383042/1
diff --git a/modules/ext.collapsiblevector.collapsibleNav.js
b/modules/ext.collapsiblevector.collapsibleNav.js
index baafba6..3b1d505 100644
--- a/modules/ext.collapsiblevector.collapsibleNav.js
+++ b/modules/ext.collapsiblevector.collapsibleNav.js
@@ -126,13 +126,13 @@
// Toggle the selected menu's class and expand or collapse the
menu
$( '#mw-panel' )
- .on( 'keydown', '.portal:not(.persistent) > h3',
function ( e ) {
+ .delegate( '.portal:not(.persistent) > h3', 'keydown',
function ( e ) {
// Make the space and enter keys act as a click
if ( e.which === 13 /* Enter */ || e.which ===
32 /* Space */ ) {
toggle( $( this ) );
}
} )
- .delegate( 'mousedown', '.portal:not(.persistent) >
h3', function ( e ) {
+ .delegate( '.portal:not(.persistent) > h3',
'mousedown', function ( e ) {
if ( e.which !== 3 ) { // Right mouse click
toggle( $( this ) );
$( this ).blur();
--
To view, visit https://gerrit.wikimedia.org/r/383042
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I91794a8a75a60af9966fcd4f1a6c3e3bd579f7c0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CollapsibleVector
Gerrit-Branch: REL1_30
Gerrit-Owner: Paladox <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
