DCausse has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/382700 )
Change subject: add elasticsearch specific forbidden-api config ...................................................................... add elasticsearch specific forbidden-api config Change-Id: I1e0c47ab10be05607f3c45573782a0ee04e1e8ad --- A src/main/resources/org/wikimedia/discovery/build/tools/forbidden/lucene-signatures.txt M src/main/resources/org/wikimedia/discovery/build/tools/forbidden/test-signatures.txt 2 files changed, 42 insertions(+), 1 deletion(-) Approvals: DCausse: Verified; Looks good to me, approved diff --git a/src/main/resources/org/wikimedia/discovery/build/tools/forbidden/lucene-signatures.txt b/src/main/resources/org/wikimedia/discovery/build/tools/forbidden/lucene-signatures.txt new file mode 100644 index 0000000..776d270 --- /dev/null +++ b/src/main/resources/org/wikimedia/discovery/build/tools/forbidden/lucene-signatures.txt @@ -0,0 +1,17 @@ +@defaultMessage Reference management is tricky, leave it to SearcherManager +org.apache.lucene.index.IndexReader#decRef() +org.apache.lucene.index.IndexReader#incRef() +org.apache.lucene.index.IndexReader#tryIncRef() + +@defaultMessage Use Lucene.parseLenient instead it strips off minor version +org.apache.lucene.util.Version#parseLeniently(java.lang.String) + +@defaultMessage Spawns a new thread which is solely under lucenes control use ThreadPool#estimatedTimeInMillisCounter instead +org.apache.lucene.search.TimeLimitingCollector#getGlobalTimerThread() +org.apache.lucene.search.TimeLimitingCollector#getGlobalCounter() + +org.apache.lucene.index.IndexWriter#maybeMerge() @ use Merges#maybeMerge +org.apache.lucene.index.IndexWriter#forceMerge(int) @ use Merges#forceMerge +org.apache.lucene.index.IndexWriter#forceMerge(int,boolean) @ use Merges#forceMerge +org.apache.lucene.index.IndexWriter#forceMergeDeletes() @ use Merges#forceMergeDeletes +org.apache.lucene.index.IndexWriter#forceMergeDeletes(boolean) @ use Merges#forceMergeDeletes diff --git a/src/main/resources/org/wikimedia/discovery/build/tools/forbidden/test-signatures.txt b/src/main/resources/org/wikimedia/discovery/build/tools/forbidden/test-signatures.txt index 2534ea8..c97e2f6 100644 --- a/src/main/resources/org/wikimedia/discovery/build/tools/forbidden/test-signatures.txt +++ b/src/main/resources/org/wikimedia/discovery/build/tools/forbidden/test-signatures.txt @@ -1 +1,25 @@ -#Almost Elasticsearch's configuration. We use this here because we have access to everything in Elasticsearch so we should play by its rules. +#Cribbed from Elasticsearch's forbidden signatures + +@defaultMessage spawns threads with vague names; use a custom thread factory and name threads so that you can tell (by its name) which executor it is associated with + +java.util.concurrent.Executors#newFixedThreadPool(int) +java.util.concurrent.Executors#newSingleThreadExecutor() +java.util.concurrent.Executors#newCachedThreadPool() +java.util.concurrent.Executors#newSingleThreadScheduledExecutor() +java.util.concurrent.Executors#newScheduledThreadPool(int) +java.util.concurrent.Executors#defaultThreadFactory() +java.util.concurrent.Executors#privilegedThreadFactory() + +java.lang.Character#codePointBefore(char[],int) @ Implicit start offset is error-prone when the char[] is a buffer and the first chars are random chars +java.lang.Character#codePointAt(char[],int) @ Implicit end offset is error-prone when the char[] is a buffer and the last chars are random chars + +@defaultMessage Only use wait / notify when really needed try to use concurrency primitives, latches or callbacks instead. +java.lang.Object#wait() +java.lang.Object#wait(long) +java.lang.Object#wait(long,int) +java.lang.Object#notify() +java.lang.Object#notifyAll() + +@defaultMessage Beware of the behavior of this method on MIN_VALUE +java.lang.Math#abs(int) +java.lang.Math#abs(long) -- To view, visit https://gerrit.wikimedia.org/r/382700 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e0c47ab10be05607f3c45573782a0ee04e1e8ad Gerrit-PatchSet: 3 Gerrit-Project: wikimedia/discovery/discovery-maven-tool-configs Gerrit-Branch: master Gerrit-Owner: Gehel <guillaume.leder...@wikimedia.org> Gerrit-Reviewer: DCausse <dcau...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
