Gehel has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383123 )
Change subject: quality annotations should be both optional and scope=provided ...................................................................... quality annotations should be both optional and scope=provided assembly plugin does not work well with optional dependencies: https://issues.apache.org/jira/browse/MASSEMBLY-529 Change-Id: I46bf0423ef6da82574703063dbe8179b601c4b9c --- M pom.xml 1 file changed, 10 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wikimedia/discovery/discovery-parent-pom refs/changes/23/383123/1 diff --git a/pom.xml b/pom.xml index ae96aab..e22e613 100644 --- a/pom.xml +++ b/pom.xml @@ -75,33 +75,37 @@ <dependencyManagement> <dependencies> <dependency> + <groupId>org.slf4j</groupId> + <artifactId>slf4j-api</artifactId> + <version>${slf4j.version}</version> + </dependency> + <dependency> <groupId>com.github.spotbugs</groupId> <artifactId>spotbugs-annotations</artifactId> <version>${spotbugs.version}</version> + <scope>provided</scope> <optional>true</optional> </dependency> <dependency> <groupId>com.google.code.findbugs</groupId> <artifactId>jsr305</artifactId> <version>3.0.2</version> + <scope>provided</scope> <optional>true</optional> </dependency> <dependency> <groupId>net.jcip</groupId> <artifactId>jcip-annotations</artifactId> <version>1.0</version> + <scope>provided</scope> <optional>true</optional> </dependency> <dependency> <groupId>org.projectlombok</groupId> <artifactId>lombok</artifactId> <version>1.16.18</version> + <scope>provided</scope> <optional>true</optional> - </dependency> - <dependency> - <groupId>org.slf4j</groupId> - <artifactId>slf4j-api</artifactId> - <version>${slf4j.version}</version> </dependency> <dependency> <groupId>org.assertj</groupId> @@ -349,7 +353,7 @@ <requireMavenVersion> <version>3.3.1</version> </requireMavenVersion> - <NoPackageCyclesRule implementation="de.andrena.tools.nopackagecycles.NoPackageCyclesRule" /> + <NoPackageCyclesRule implementation="de.andrena.tools.nopackagecycles.NoPackageCyclesRule"></NoPackageCyclesRule> </rules> </configuration> <dependencies> -- To view, visit https://gerrit.wikimedia.org/r/383123 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I46bf0423ef6da82574703063dbe8179b601c4b9c Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/discovery/discovery-parent-pom Gerrit-Branch: master Gerrit-Owner: Gehel <guillaume.leder...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
