Hashar has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/383159 )

Change subject: Running global-setup.sh is useless
......................................................................

Running global-setup.sh is useless

It mostly set environment variable but each of our run_script ends up
with a fresh environment. Hence global-setup.sh is useless here.

Moreover, it tries to create a tmp directory in /nonexistent which is a
nono when running as nobody.

Change-Id: I6345a674641aca37135808505aa910d484e4ad1e
---
M quibble/cmd.py
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/quibble 
refs/changes/59/383159/1

diff --git a/quibble/cmd.py b/quibble/cmd.py
index 1de5ba2..0116643 100644
--- a/quibble/cmd.py
+++ b/quibble/cmd.py
@@ -137,7 +137,6 @@
                 script, proc.returncode))
 
     def mw_install(self):
-        self.run_script('global-setup.sh')
         self.run_script('mw-install-mysql.sh')
         self.run_script('mw-apply-settings.sh')
         self.run_script('mw-run-update-script.sh')

-- 
To view, visit https://gerrit.wikimedia.org/r/383159
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6345a674641aca37135808505aa910d484e4ad1e
Gerrit-PatchSet: 1
Gerrit-Project: integration/quibble
Gerrit-Branch: master
Gerrit-Owner: Hashar <has...@free.fr>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to