jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/383091 )
Change subject: SearchInputWidget: Actually connect to change event
......................................................................
SearchInputWidget: Actually connect to change event
This makes the clear indicator-button work, not sure if it
ever worked in the past.
Change-Id: Ia54add0fa5475c37871d82e7750ea4dedbf9dfe3
---
M resources/src/mediawiki.widgets/mw.widgets.SearchInputWidget.js
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/src/mediawiki.widgets/mw.widgets.SearchInputWidget.js
b/resources/src/mediawiki.widgets/mw.widgets.SearchInputWidget.js
index 8707bfa..194f714 100644
--- a/resources/src/mediawiki.widgets/mw.widgets.SearchInputWidget.js
+++ b/resources/src/mediawiki.widgets/mw.widgets.SearchInputWidget.js
@@ -67,6 +67,10 @@
} );
}.bind( this ) );
+ this.connect( this, {
+ change: 'onChange'
+ } );
+
this.$element.addClass( 'oo-ui-textInputWidget-type-search' );
this.updateSearchIndicator();
this.connect( this, {
@@ -117,7 +121,6 @@
* @see OO.ui.SearchInputWidget#onChange
*/
mw.widgets.SearchInputWidget.prototype.onChange = function () {
- mw.widgets.SearchInputWidget.parent.prototype.onChange.call(
this );
this.updateSearchIndicator();
};
--
To view, visit https://gerrit.wikimedia.org/r/383091
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia54add0fa5475c37871d82e7750ea4dedbf9dfe3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
