Jonas Kress (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383522 )
Change subject: Allow rendering BubbleChart with some rows missing a number ...................................................................... Allow rendering BubbleChart with some rows missing a number Modify _getNumberColumns() to not only look at first row. Make BubbleChartResultBrowser more resilient against null values. Example query: http://tinyurl.com/ycqew4ov Change-Id: I29ad6c8ac53fb5f485a082ef112cfdecabc76b51 --- M wikibase/queryService/ui/resultBrowser/AbstractChartResultBrowser.js M wikibase/queryService/ui/resultBrowser/BubbleChartResultBrowser.js 2 files changed, 7 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui refs/changes/22/383522/1 diff --git a/wikibase/queryService/ui/resultBrowser/AbstractChartResultBrowser.js b/wikibase/queryService/ui/resultBrowser/AbstractChartResultBrowser.js index 75ed234..b8d2f19 100644 --- a/wikibase/queryService/ui/resultBrowser/AbstractChartResultBrowser.js +++ b/wikibase/queryService/ui/resultBrowser/AbstractChartResultBrowser.js @@ -43,10 +43,14 @@ **/ SELF.prototype._getNumberColumns = function() { var self = this, - row = self._getRows()[0]; + rows = self._getRows(); return self._getColumns().filter( function( column ) { - return self._getFormatter().isNumber( row[column] ); + return rows.some( function( row ) { + if ( row[column] && self._getFormatter().isNumber( row[column] ) ) { + return true; + } + } ); } ); }; diff --git a/wikibase/queryService/ui/resultBrowser/BubbleChartResultBrowser.js b/wikibase/queryService/ui/resultBrowser/BubbleChartResultBrowser.js index 9f9ff92..0df4e2a 100644 --- a/wikibase/queryService/ui/resultBrowser/BubbleChartResultBrowser.js +++ b/wikibase/queryService/ui/resultBrowser/BubbleChartResultBrowser.js @@ -65,7 +65,7 @@ if ( field && field.value && self._getFormatter().isEntityUri( field.value ) ) { var createdItem = data.children[data.children.length - 1]; - if ( createdItem.url === null ) { + if ( createdItem && createdItem.url === null ) { createdItem.url = field.value; } } -- To view, visit https://gerrit.wikimedia.org/r/383522 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I29ad6c8ac53fb5f485a082ef112cfdecabc76b51 Gerrit-PatchSet: 1 Gerrit-Project: wikidata/query/gui Gerrit-Branch: master Gerrit-Owner: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
