jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/383582 )
Change subject: Hygiene: Icon color transition follow up (#2) ...................................................................... Hygiene: Icon color transition follow up (#2) Removes obsolete comments and directives from the page action menu xml. Change-Id: Icb3bc2d65cd1d8905fe31e40e2e1f37744aa1544 --- M app/src/main/res/menu/menu_page_actions.xml 1 file changed, 1 insertion(+), 10 deletions(-) Approvals: Dbrant: Looks good to me, approved jenkins-bot: Verified diff --git a/app/src/main/res/menu/menu_page_actions.xml b/app/src/main/res/menu/menu_page_actions.xml index b132039..e50d383 100644 --- a/app/src/main/res/menu/menu_page_actions.xml +++ b/app/src/main/res/menu/menu_page_actions.xml @@ -1,14 +1,6 @@ <?xml version="1.0" encoding="utf-8"?> - <menu xmlns:android="http://schemas.android.com/apk/res/android"; - xmlns:app="http://schemas.android.com/apk/res-auto"; - xmlns:tools="http://schemas.android.com/tools"; - tools:ignore="AlwaysShowAction"> - <!-- - Some of the items in this menu are marked with showAsAction="always" on purpose: - We truly want the "search" and "tabs" buttons to always be shown in the toolbar, even on small - screens, instead of overflowing into the native overflow menu. - --> + xmlns:app="http://schemas.android.com/apk/res-auto";> <item android:id="@+id/menu_page_other_languages" android:title="@string/menu_page_other_languages" app:showAsAction="never" @@ -37,5 +29,4 @@ android:title="@string/menu_page_font_and_theme" app:showAsAction="never" android:enabled="false" /> - </menu> -- To view, visit https://gerrit.wikimedia.org/r/383582 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb3bc2d65cd1d8905fe31e40e2e1f37744aa1544 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Mholloway <mhollo...@wikimedia.org> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: Cooltey <cf...@wikimedia.org> Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org> Gerrit-Reviewer: Sharvaniharan <sha...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
