jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/383610 )
Change subject: Downgrade 'grunt-exec' to 1.0.1
......................................................................
Downgrade 'grunt-exec' to 1.0.1
The later versions are completely broken on Windows.
Version 2.0 of grunt-exec is a complete rewrite (for no documented
reason) to split the given command line into the command and arguments
and use child_process.spawn() instead of child_process.exec().
Unfortunately the splitting code is broken (e.g. doesn't handle '&&',
instead passes it as an argument to the first command) and the
spawning code is apparently also broken (trying to spawn 'composer',
which resolves to 'composer.bat', behaves as if the file didn't
exist).
Version 3.0 is an avoidable followup release because in addition to
the issues above something about quote parsing was also broken.
These issues are not visible on other operating systems because
apparently the developer noticed the brokenness on his machine and
special-cased non-Windows systems to not do the broken parsing.
Presumably the behavior on Windows was never tested.
There is no changelog for any of these changes.
I think we should never update this package again, and evaluate
switching to a different one. It seems to have been taken over by a
different developer than the original one and he doesn't know what
he's doing.
Change-Id: Ie958df88affff51af377d518a4364c66ed61d2fe
---
M package.json
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
VolkerE: Looks good to me, but someone else must approve
Jforrester: Looks good to me, approved
diff --git a/package.json b/package.json
index ecf2413..39fd7c8 100644
--- a/package.json
+++ b/package.json
@@ -40,7 +40,7 @@
"grunt-contrib-watch": "1.0.0",
"grunt-cssjanus": "0.4.0",
"grunt-eslint": "20.0.0",
- "grunt-exec": "3.0.0",
+ "grunt-exec": "1.0.1",
"grunt-file-exists": "0.1.4",
"grunt-image": "1.5.2",
"grunt-jsonlint": "1.1.0",
--
To view, visit https://gerrit.wikimedia.org/r/383610
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie958df88affff51af377d518a4364c66ed61d2fe
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
