jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/383637 )
Change subject: Short-circuit in ItemNotabilityFilter if list of item ids is
empty
......................................................................
Short-circuit in ItemNotabilityFilter if list of item ids is empty
Bug: T177980
Change-Id: Id73517526ced0abb85b23d27e8c3aa2cb84a40a0
---
M includes/ItemNotabilityFilter.php
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
jenkins-bot: Verified
Thiemo Mättig (WMDE): Looks good to me, approved
diff --git a/includes/ItemNotabilityFilter.php
b/includes/ItemNotabilityFilter.php
index d9f858b..b71bbb5 100644
--- a/includes/ItemNotabilityFilter.php
+++ b/includes/ItemNotabilityFilter.php
@@ -73,6 +73,10 @@
* @return ItemId[]
*/
public function getNotableEntityIds( array $itemIds ) {
+ if ( $itemIds === [] ) {
+ return [];
+ }
+
$numericItemIds = [];
$statementClaimsCount = $this->getStatementClaimsCount(
$itemIds );
@@ -152,6 +156,10 @@
* @return ItemId[]
*/
private function getItemsWithoutArticle( array $numericItemIds ) {
+ if ( $numericItemIds === [] ) {
+ return [];
+ }
+
$itemIds = [];
$links = $this->siteLinkLookup->getLinks( $numericItemIds, [
$this->siteGlobalId ] );
--
To view, visit https://gerrit.wikimedia.org/r/383637
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id73517526ced0abb85b23d27e8c3aa2cb84a40a0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticlePlaceholder
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Lucie Kaffee <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
