Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383724 )
Change subject: Tablet modules no longer managed by MobileFrontend
......................................................................
Tablet modules no longer managed by MobileFrontend
Change-Id: Ie52565a72660fd0f407e5bda325c9e93899bd621
Depends-On: I32e2b4a10799a06138bfee08abc6769a6b96004d
Bug: T173454
---
M resources/mobile.startup/Skin.js
1 file changed, 1 insertion(+), 26 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/24/383724/1
diff --git a/resources/mobile.startup/Skin.js b/resources/mobile.startup/Skin.js
index 0569614..9e355a9 100644
--- a/resources/mobile.startup/Skin.js
+++ b/resources/mobile.startup/Skin.js
@@ -56,30 +56,7 @@
mw.log.warn( 'Skin: Use of mainMenu is deprecated.' );
}
View.call( this, options );
- // Must be run after merging with defaults as must be defined.
- this.tabletModules = options.tabletModules;
this.referencesGateway = options.referencesGateway;
-
- /**
- * Tests current window size and if suitable loads styles and
scripts specific for larger devices
- *
- * @method
- * @ignore
- */
- function loadWideScreenModules() {
- if ( browser.isWideScreen() ) {
- // Adjust screen for tablets
- if ( self.page.inNamespace( '' ) ) {
- mw.loader.using( self.tabletModules
).always( function () {
- self.off( '_resize' );
- self.emit( 'changed' );
- } );
- }
- }
- }
- M.on( 'resize', $.proxy( this, 'emit', '_resize' ) );
- this.on( '_resize', loadWideScreenModules );
- this.emit( '_resize' );
if (
mw.config.get( 'wgMFLazyLoadImages' )
@@ -104,12 +81,10 @@
* @inheritdoc
* @cfg {Object} defaults Default options hash.
* @cfg {Page} defaults.page page the skin is currently
rendering
- * @cfg {Array} defaults.tabletModules modules to load when in
tablet
* @cfg {ReferencesGateway} defaults.referencesGateway instance
of references gateway
*/
defaults: {
- page: undefined,
- tabletModules: []
+ page: undefined
},
/**
--
To view, visit https://gerrit.wikimedia.org/r/383724
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie52565a72660fd0f407e5bda325c9e93899bd621
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
