jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/383644 )
Change subject: Improve some parameter docs
......................................................................
Improve some parameter docs
Change-Id: I1dc282082769a67a07ffdfa17b6dfe72e22594bc
---
M ContactPage_body.php
M phpcs.xml
2 files changed, 4 insertions(+), 8 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/ContactPage_body.php b/ContactPage_body.php
index 86d2730..5a435e0 100644
--- a/ContactPage_body.php
+++ b/ContactPage_body.php
@@ -25,6 +25,7 @@
$wgContactConfig['default']['SenderName'] = "Contact
Form on $wgSitename";
}
}
+
/**
* Constructor
*/
@@ -33,7 +34,7 @@
}
/**
- * @see SpecialPage::getDescription
+ * @inheritDoc
*/
function getDescription() {
return $this->msg( 'contactpage' )->text();
@@ -58,7 +59,7 @@
/**
* Main execution function
*
- * @param $par Mixed: Parameters passed to the page
+ * @param string|null $par Parameters passed to the page
* @throws UserBlockedError
* @throws ErrorPageError
*/
diff --git a/phpcs.xml b/phpcs.xml
index 8cafc07..53b90b0 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -2,15 +2,10 @@
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamName" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingReturn" />
<exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
<exclude
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
</rule>
<file>.</file>
<arg name="extensions" value="php,php5,inc" />
- <arg name="encoding" value="utf8" />
- <exclude-pattern>vendor</exclude-pattern>
- <exclude-pattern>node_modules</exclude-pattern>
+ <arg name="encoding" value="UTF-8" />
</ruleset>
--
To view, visit https://gerrit.wikimedia.org/r/383644
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1dc282082769a67a07ffdfa17b6dfe72e22594bc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContactPage
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
