[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: Remove dead placeholder code

[Jeroen De Dauw (Code Review)]

Jeroen De Dauw has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/383771 )

Change subject: Remove dead placeholder code
......................................................................

Remove dead placeholder code

Dead as far as I can tell...

Change-Id: I7181c68249591197689b7388402495a39465d8fb
---
M modules/ext.advancedSearch.init.js
1 file changed, 0 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AdvancedSearch 
refs/changes/71/383771/1

diff --git a/modules/ext.advancedSearch.init.js 
b/modules/ext.advancedSearch.init.js
index 48a4291..1f01c17 100644
--- a/modules/ext.advancedSearch.init.js
+++ b/modules/ext.advancedSearch.init.js
@@ -138,7 +138,6 @@
                {
                        group: 'text',
                        id: 'plain',
-                       placeholder: '…',
                        formatter: function ( val ) {
                                return val;
                        }
@@ -146,7 +145,6 @@
                {
                        group: 'text',
                        id: 'phrase',
-                       placeholder: '"…"',
                        formatter: function ( val ) {
                                if ( Array.isArray( val ) ) {
                                        return $.map( val, enforceQuotes 
).join( ' ' );
@@ -163,7 +161,6 @@
                {
                        group: 'text',
                        id: 'not',
-                       placeholder: '-…',
                        formatter: function ( val ) {
                                return '-' + optionalQuotes( val );
                        }
@@ -171,7 +168,6 @@
                {
                        group: 'text',
                        id: 'or',
-                       placeholder: '…OR',
                        formatter: function ( val ) {
                                if ( Array.isArray( val ) ) {
                                        return $.map( val, optionalQuotes 
).join( ' OR ' );
@@ -189,7 +185,6 @@
                {
                        group: 'structure',
                        id: 'intitle',
-                       placeholder: 'intitle:…',
                        formatter: function ( val ) {
                                return 'intitle:' + optionalQuotes( val );
                        }
@@ -198,7 +193,6 @@
                {
                        group: 'structure',
                        id: 'hastemplate',
-                       placeholder: 'hastemplate:…',
                        formatter: function ( val ) {
                                if ( Array.isArray( val ) ) {
                                        return $.map( val, function ( 
templateItem ) {
@@ -218,7 +212,6 @@
                {
                        group: 'structure',
                        id: 'insource',
-                       placeholder: 'insource:…',
                        formatter: function ( val ) {
                                return 'insource:' + ( /^\/.*\/$/.test( val ) ? 
val : optionalQuotes( val ) );
                        }
@@ -230,7 +223,6 @@
                {
                        group: 'files',
                        id: 'filetype',
-                       placeholder: 'filetype:…',
                        formatter: function ( val ) {
                                switch ( val ) {
 
@@ -261,7 +253,6 @@
                {
                        group: 'files',
                        id: 'filew',
-                       placeholder: 'filew:…',
                        formatter: function ( val ) {
                                return formatSizeConstraint( 'filew:', val );
                        },
@@ -279,7 +270,6 @@
                {
                        group: 'files',
                        id: 'fileh',
-                       placeholder: 'fileh:…',
                        formatter: function ( val ) {
                                return formatSizeConstraint( 'fileh:', val );
                        },

-- 
To view, visit https://gerrit.wikimedia.org/r/383771
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7181c68249591197689b7388402495a39465d8fb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AdvancedSearch
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits