Rush has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/383896 )
Change subject: openstack: labs-ip-alias-dump as a cron rather than exec
......................................................................
openstack: labs-ip-alias-dump as a cron rather than exec
This takes a full minute to run even as a noop and sometimes
inline with a puppet run will take much longer for actual
updates. It is also not running any time we are doing
legit maintenance. I want to avoid running expected and
regular operations via exec as a cron substitute.
Change-Id: I2d5aebe378b54674c7dd0bb7701e82f2d83f9153
---
M modules/dnsrecursor/manifests/labsaliaser.pp
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Rush: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/dnsrecursor/manifests/labsaliaser.pp
b/modules/dnsrecursor/manifests/labsaliaser.pp
index 1e9c9c7..82a05c7 100644
--- a/modules/dnsrecursor/manifests/labsaliaser.pp
+++ b/modules/dnsrecursor/manifests/labsaliaser.pp
@@ -34,14 +34,15 @@
source => 'puppet:///modules/dnsrecursor/labs-ip-alias-dump.py',
}
- exec { '/usr/local/bin/labs-ip-alias-dump.py':
+ cron { 'labs-ip-alias-dump':
+ ensure => 'present',
user => 'root',
- group => 'root',
+ command => '/usr/local/bin/labs-ip-alias-dump.py --check-changes-only
|| /usr/local/bin/labs-ip-alias-dump.py',
+ minute => 30,
notify => Service['pdns-recursor'],
require => File[
'/usr/local/bin/labs-ip-alias-dump.py',
'/etc/labs-dns-alias.yaml'
],
- unless => '/usr/local/bin/labs-ip-alias-dump.py --check-changes-only',
}
}
--
To view, visit https://gerrit.wikimedia.org/r/383896
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2d5aebe378b54674c7dd0bb7701e82f2d83f9153
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Rush <r...@wikimedia.org>
Gerrit-Reviewer: Andrew Bogott <abog...@wikimedia.org>
Gerrit-Reviewer: Rush <r...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
