Hello Daniel Kinzler, Tim Starling, Legoktm,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/383921
to review the following change.
Change subject: Update for deprecation of selectFields() methods
......................................................................
Update for deprecation of selectFields() methods
Various selectFields() methods were deprecated in MediaWiki core change
Idcfd1556. This change adapts the extension to use the replacement
getQueryInfo() methods when available.
Change-Id: I0d869aacaaad85cdd34361a611ac8348bdbb757d
---
M includes/specials/SpecialMobileHistory.php
1 file changed, 12 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/21/383921/1
diff --git a/includes/specials/SpecialMobileHistory.php
b/includes/specials/SpecialMobileHistory.php
index d8760dd..20fff25 100644
--- a/includes/specials/SpecialMobileHistory.php
+++ b/includes/specials/SpecialMobileHistory.php
@@ -156,10 +156,19 @@
$options['LIMIT'] = self::LIMIT + 1;
- $tables = [ self::DB_REVISIONS_TABLE ];
- $fields = Revision::selectFields();
+ if ( is_callable( Revision::class, 'getQueryInfo' ) ) {
+ $revQuery = Revision::getQueryInfo();
+ } else {
+ $revQuery = [
+ 'tables' => [ self::DB_REVISIONS_TABLE ],
+ 'fields' => Revision::selectFields(),
+ 'joins' => [],
+ ];
+ }
- $res = $dbr->select( $tables, $fields, $conds, __METHOD__,
$options );
+ $res = $dbr->select(
+ $revQuery['tables'], $revQuery['fields'], $conds,
__METHOD__, $options, $revQuery['joins']
+ );
return $res;
}
--
To view, visit https://gerrit.wikimedia.org/r/383921
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d869aacaaad85cdd34361a611ac8348bdbb757d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Anomie <bjor...@wikimedia.org>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Tim Starling <tstarl...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
