jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/383947 )
Change subject: mw.rcfilters.Controller: Avoid ES6 method String#endsWith
......................................................................
mw.rcfilters.Controller: Avoid ES6 method String#endsWith
We still support ES5 browsers such as Internet Explorer 11 and Opera 12.
Bug: T178120
Change-Id: Ic85063dfbbcf26a99d343845c9fb801f1888d750
---
M resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Mooeypoo: Looks good to me, approved
diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
index 6da8119..4bc6183 100644
--- a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
+++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
@@ -386,7 +386,7 @@
this._deleteExcludedValuesFromFilterState( defaultFilters );
if ( Object.keys( defaultParams ).some( function ( paramName ) {
- return paramName.endsWith( '_color' ) && defaultParams[
paramName ] !== null;
+ return paramName.match( /_color$/ ) && defaultParams[
paramName ] !== null;
} ) ) {
// There are highlights in the defaults, they're
definitely
// not empty
--
To view, visit https://gerrit.wikimedia.org/r/383947
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic85063dfbbcf26a99d343845c9fb801f1888d750
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Catrope <r...@wikimedia.org>
Gerrit-Reviewer: Mooeypoo <mor...@gmail.com>
Gerrit-Reviewer: Sbisson <sbis...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
