Thiemo Mättig (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/384044 )
Change subject: Use assertEmpty instead of assertCount( 0, … )
......................................................................
Use assertEmpty instead of assertCount( 0, … )
It's sematnically the same. I would argue it's a little easier to
read and to understand.
Change-Id: I1817d8d526ad1925ae19b3d979665a8e1f9a2c41
---
M tests/phpunit/Checker/ConnectionChecker/SymmetricCheckerTest.php
M tests/phpunit/Checker/QualifierChecker/QualifierCheckerTest.php
M tests/phpunit/Checker/ReferenceCheckerTest.php
M tests/phpunit/Checker/ValueCountChecker/MultiValueCheckerTest.php
M tests/phpunit/Checker/ValueCountChecker/SingleValueCheckerTest.php
M tests/phpunit/Checker/ValueCountChecker/UniqueValueCheckerTest.php
M tests/phpunit/Checker/ValueOnlyCheckerTest.php
M tests/phpunit/DelegatingConstraintCheckerTest.php
8 files changed, 11 insertions(+), 11 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityConstraints
refs/changes/44/384044/1
diff --git a/tests/phpunit/Checker/ConnectionChecker/SymmetricCheckerTest.php
b/tests/phpunit/Checker/ConnectionChecker/SymmetricCheckerTest.php
index 94f8bfe..70bfb00 100644
--- a/tests/phpunit/Checker/ConnectionChecker/SymmetricCheckerTest.php
+++ b/tests/phpunit/Checker/ConnectionChecker/SymmetricCheckerTest.php
@@ -145,7 +145,7 @@
$result = $this->checker->checkConstraintParameters(
$constraint );
- $this->assertCount( 0, $result );
+ $this->assertEmpty( $result );
}
/**
diff --git a/tests/phpunit/Checker/QualifierChecker/QualifierCheckerTest.php
b/tests/phpunit/Checker/QualifierChecker/QualifierCheckerTest.php
index c62646a..4ec569c 100644
--- a/tests/phpunit/Checker/QualifierChecker/QualifierCheckerTest.php
+++ b/tests/phpunit/Checker/QualifierChecker/QualifierCheckerTest.php
@@ -85,7 +85,7 @@
$result = $checker->checkConstraintParameters( $constraint );
- $this->assertCount( 0, $result );
+ $this->assertEmpty( $result );
}
/**
diff --git a/tests/phpunit/Checker/ReferenceCheckerTest.php
b/tests/phpunit/Checker/ReferenceCheckerTest.php
index e4420a6..4e24634 100644
--- a/tests/phpunit/Checker/ReferenceCheckerTest.php
+++ b/tests/phpunit/Checker/ReferenceCheckerTest.php
@@ -73,7 +73,7 @@
$result = $checker->checkConstraintParameters( $constraint );
- $this->assertCount( 0, $result );
+ $this->assertEmpty( $result );
}
/**
diff --git a/tests/phpunit/Checker/ValueCountChecker/MultiValueCheckerTest.php
b/tests/phpunit/Checker/ValueCountChecker/MultiValueCheckerTest.php
index 5f7b8f7..5d1c64e 100644
--- a/tests/phpunit/Checker/ValueCountChecker/MultiValueCheckerTest.php
+++ b/tests/phpunit/Checker/ValueCountChecker/MultiValueCheckerTest.php
@@ -100,7 +100,7 @@
$result = $this->checker->checkConstraintParameters(
$constraint );
- $this->assertCount( 0, $result );
+ $this->assertEmpty( $result );
}
/**
diff --git a/tests/phpunit/Checker/ValueCountChecker/SingleValueCheckerTest.php
b/tests/phpunit/Checker/ValueCountChecker/SingleValueCheckerTest.php
index dcba46b..d0eb510 100644
--- a/tests/phpunit/Checker/ValueCountChecker/SingleValueCheckerTest.php
+++ b/tests/phpunit/Checker/ValueCountChecker/SingleValueCheckerTest.php
@@ -100,7 +100,7 @@
$result = $this->checker->checkConstraintParameters(
$constraint );
- $this->assertCount( 0, $result );
+ $this->assertEmpty( $result );
}
/**
diff --git a/tests/phpunit/Checker/ValueCountChecker/UniqueValueCheckerTest.php
b/tests/phpunit/Checker/ValueCountChecker/UniqueValueCheckerTest.php
index 5200c05..1b2e0de 100644
--- a/tests/phpunit/Checker/ValueCountChecker/UniqueValueCheckerTest.php
+++ b/tests/phpunit/Checker/ValueCountChecker/UniqueValueCheckerTest.php
@@ -188,7 +188,7 @@
$result = $this->checker->checkConstraintParameters(
$constraint );
- $this->assertCount( 0, $result );
+ $this->assertEmpty( $result );
}
/**
diff --git a/tests/phpunit/Checker/ValueOnlyCheckerTest.php
b/tests/phpunit/Checker/ValueOnlyCheckerTest.php
index b3bba1f..2c98955 100644
--- a/tests/phpunit/Checker/ValueOnlyCheckerTest.php
+++ b/tests/phpunit/Checker/ValueOnlyCheckerTest.php
@@ -73,7 +73,7 @@
$result = $checker->checkConstraintParameters( $constraint );
- $this->assertCount( 0, $result );
+ $this->assertEmpty( $result );
}
/**
diff --git a/tests/phpunit/DelegatingConstraintCheckerTest.php
b/tests/phpunit/DelegatingConstraintCheckerTest.php
index 6cb6b7b..eafa1c8 100644
--- a/tests/phpunit/DelegatingConstraintCheckerTest.php
+++ b/tests/phpunit/DelegatingConstraintCheckerTest.php
@@ -361,7 +361,7 @@
$result =
$this->constraintChecker->checkAgainstConstraintsOnEntityId( $entity->getId() );
- $this->assertCount( 0, $result, 'Should be empty' );
+ $this->assertEmpty( $result );
}
public function testCheckOnEntityIdUnknownConstraint() {
@@ -389,7 +389,7 @@
$result =
$this->constraintChecker->checkAgainstConstraintsOnEntityId( $entity->getId() );
- $this->assertCount( 0, $result, 'Should be empty' );
+ $this->assertEmpty( $result );
}
public function testCheckOnEntityIdKnownException() {
@@ -498,14 +498,14 @@
$statement->getGuid()
);
- $this->assertCount( 0, $result, 'Should be empty' );
+ $this->assertEmpty( $result );
}
public function testCheckOnClaimIdUnknownClaimId() {
$result =
$this->constraintChecker->checkAgainstConstraintsOnClaimId(
'Q99$does-not-exist' );
- $this->assertCount( 0, $result, 'Should be empty' );
+ $this->assertEmpty( $result );
}
public function testCheckConstraintParametersOnPropertyId() {
--
To view, visit https://gerrit.wikimedia.org/r/384044
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1817d8d526ad1925ae19b3d979665a8e1f9a2c41
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
