Petar.petkovic has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384182 )
Change subject: Change New translation input placeholder ...................................................................... Change New translation input placeholder - Change placeholder message from "Search for source page" to "Search for a page to translate", because New translation dialog does not provide option to set target page title, therefore making source page concept not very intuitive. Bug: T111094 Change-Id: Ieb28e58e451f0394b0100b94c6eda76a145c9bcc --- M extension.json M i18n/en.json M i18n/qqq.json M modules/source/ext.cx.source.selector.js 4 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation refs/changes/82/384182/1 diff --git a/extension.json b/extension.json index 1da09f5..402b8fb 100644 --- a/extension.json +++ b/extension.json @@ -362,6 +362,7 @@ "cx-sourceselector-dialog-button-cancel", "cx-sourceselector-dialog-source-language-label", "cx-sourceselector-dialog-target-language-label", + "cx-sourceselector-embedded-source-page-placeholder", "cx-sourceselector-dialog-source-title-placeholder", "cx-sourceselector-dialog-target-title-placeholder", "cx-sourceselector-dialog-error-page-and-title-exist", diff --git a/i18n/en.json b/i18n/en.json index 41d3cab..e9b2458 100644 --- a/i18n/en.json +++ b/i18n/en.json @@ -91,6 +91,7 @@ "cx-sourceselector-dialog-button-cancel": "Cancel", "cx-sourceselector-dialog-source-language-label": "From:", "cx-sourceselector-dialog-target-language-label": "To:", + "cx-sourceselector-embedded-source-page-placeholder": "Search for a page to translate", "cx-sourceselector-dialog-source-title-placeholder": "Search for source page", "cx-sourceselector-dialog-target-title-placeholder": "Translation title", "cx-sourceselector-dialog-error-page-and-title-exist": "This title is already used in [$1 $2] for [$3 a different page]", diff --git a/i18n/qqq.json b/i18n/qqq.json index 550145d..9e84750 100644 --- a/i18n/qqq.json +++ b/i18n/qqq.json @@ -100,6 +100,7 @@ "cx-sourceselector-dialog-button-cancel": "Button label for translation selector. Clicking on it cancels new translation and hides dialog. Only appears when translation selector is presented as a dialog.\n{{Identical|Cancel}}", "cx-sourceselector-dialog-source-language-label": "Label text for source language and title selector.\n{{Identical|From}}", "cx-sourceselector-dialog-target-language-label": "Label text for target language and title selector.\n{{Identical|To}}", + "cx-sourceselector-embedded-source-page-placeholder": "Placeholder for the source page input field. Used on Content Translation page for new translation dialog and provides prompt to search for source page to start translation.", "cx-sourceselector-dialog-source-title-placeholder": "Placeholder for the source title input. Provides prompt to search for source title.", "cx-sourceselector-dialog-target-title-placeholder": "Placeholder for the target title input. Provides prompt to enter translation title (optional).", "cx-sourceselector-dialog-error-page-and-title-exist": "An error message that indicates that there is page in the target wiki with the same title as the proposed source title and the target title is used elsewhere.\n\nParameters:\n* $1 - link to existing target page.\n* $2 - target language name.\n* $3 - link to article using proposed target title.", diff --git a/modules/source/ext.cx.source.selector.js b/modules/source/ext.cx.source.selector.js index 7018a0c..7bd4eb1 100644 --- a/modules/source/ext.cx.source.selector.js +++ b/modules/source/ext.cx.source.selector.js @@ -1362,7 +1362,7 @@ siteMapper: this.siteMapper, value: this.options.sourceTitle, validateTitle: true, - placeholder: mw.msg( 'cx-sourceselector-dialog-source-title-placeholder' ), + placeholder: mw.msg( 'cx-sourceselector-embedded-source-page-placeholder' ), showRedirectTargets: true, $overlay: this.$searchResults, $container: this.$searchResults -- To view, visit https://gerrit.wikimedia.org/r/384182 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieb28e58e451f0394b0100b94c6eda76a145c9bcc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ContentTranslation Gerrit-Branch: master Gerrit-Owner: Petar.petkovic <ppetko...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits