Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/384500 )

Change subject: WIP Run Wikibase daily browser tests on Jenkins
......................................................................

WIP Run Wikibase daily browser tests on Jenkins

BUG: T167432
Change-Id: I7f9b0bab5b4ea4c9f96031cf4b65ed5b51698db3
---
M tests/browser/environments.yml
M tests/browser/features/step_definitions/entity_steps.rb
M tests/browser/features/support/pages/item_page.rb
3 files changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/00/384500/1

diff --git a/tests/browser/environments.yml b/tests/browser/environments.yml
index 50e0d21..61c8b52 100644
--- a/tests/browser/environments.yml
+++ b/tests/browser/environments.yml
@@ -33,7 +33,7 @@
   browser: firefox
   mediawiki_url: https://wikidata.beta.wmflabs.org/wiki/
   mediawiki_user: Selenium_user
-  user_factory: true
+  user_factory: false
   # mediawiki_password: SET THIS IN THE ENVIRONMENT!
 
 test:
diff --git a/tests/browser/features/step_definitions/entity_steps.rb 
b/tests/browser/features/step_definitions/entity_steps.rb
index 80ebf6a..8602e7c 100644
--- a/tests/browser/features/step_definitions/entity_steps.rb
+++ b/tests/browser/features/step_definitions/entity_steps.rb
@@ -41,7 +41,7 @@
 
 Given(/^I have an item with label "(.*)" and description "(.*)"$/) do |label, 
description|
   item_data = '{"labels":{"en":{"language":"en","value":"' + label + 
'"}},"descriptions":{"en":{"language":"en","value":"' + description + '"}}}'
-  @item_under_test = visit(ItemPage).create_item(item_data)
+  @item_under_test = visit(ItemPage).create_item(item_data, user, password)
 end
 
 Given(/^I am on the page of the item to test$/) do
diff --git a/tests/browser/features/support/pages/item_page.rb 
b/tests/browser/features/support/pages/item_page.rb
index 4dc63e2..78398c4 100644
--- a/tests/browser/features/support/pages/item_page.rb
+++ b/tests/browser/features/support/pages/item_page.rb
@@ -24,8 +24,9 @@
     item_data
   end
 
-  def create_item(data)
+  def create_item(data, user = nil, password = nil)
     wb_api = MediawikiApi::Wikidata::WikidataClient.new URL.repo_api
+    wb_api.log_in(user, password) if (user and password)
     resp = wb_api.create_item(data)
 
     id = resp['entity']['id']

-- 
To view, visit https://gerrit.wikimedia.org/r/384500
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f9b0bab5b4ea4c9f96031cf4b65ed5b51698db3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to