Cicalese has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/384916 )

Change subject: Fix login button label to accept RawMessage.
......................................................................

Fix login button label to accept RawMessage.

The label is already a Message at this point. For Messages that
are not RawMessages, the call to wfMessage() does not do any harm.
However, for RawMessages, it causes the label to appear in <>.
Removing the call to wfMessage() does not harm regular Messages
and fixes the problem for RawMessages.

Change-Id: I943628e2a1fbf6fff579dd52c1058ca2ef125d34
(cherry picked from commit b1ddb0cef127d75e2045d4cc3aba4d612b2f7676)
---
M includes/specialpage/AuthManagerSpecialPage.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/16/384916/1

diff --git a/includes/specialpage/AuthManagerSpecialPage.php 
b/includes/specialpage/AuthManagerSpecialPage.php
index fbc3022a..5dfe279 100644
--- a/includes/specialpage/AuthManagerSpecialPage.php
+++ b/includes/specialpage/AuthManagerSpecialPage.php
@@ -679,7 +679,7 @@
                ];
 
                if ( $type === 'submit' && isset( $singleFieldInfo['label'] ) ) 
{
-                       $descriptor['default'] = wfMessage( 
$singleFieldInfo['label'] )->plain();
+                       $descriptor['default'] = 
$singleFieldInfo['label']->plain();
                } elseif ( $type !== 'submit' ) {
                        $descriptor += array_filter( [
                                // help-message is omitted as it is usually not 
really useful for a web interface

-- 
To view, visit https://gerrit.wikimedia.org/r/384916
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I943628e2a1fbf6fff579dd52c1058ca2ef125d34
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_29
Gerrit-Owner: Cicalese <ccical...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to