jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/383953 )
Change subject: Chore: improve page revision route typing
......................................................................
Chore: improve page revision route typing
Require page revisions to be a number externally through the API.
Change-Id: I7f58eae45144f2f7a2dd35980e10d4b8d68b398c
---
M src/common/routers/api.ts
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jhernandez: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/common/routers/api.ts b/src/common/routers/api.ts
index 59a3b88..c0a7705 100644
--- a/src/common/routers/api.ts
+++ b/src/common/routers/api.ts
@@ -21,7 +21,7 @@
});
export const wiki: Route<WikiParams, WikiProps> = newRoute({
- path: "/wiki/:title/:revision?",
+ path: "/wiki/:title/:revision(\\d+)?",
importModule: () =>
import(/* webpackChunkName: "pages/wiki" */ "../pages/wiki"),
chunkName: "pages/wiki"
--
To view, visit https://gerrit.wikimedia.org/r/383953
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f58eae45144f2f7a2dd35980e10d4b8d68b398c
Gerrit-PatchSet: 5
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: Jhernandez <jhernan...@wikimedia.org>
Gerrit-Reviewer: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: Sniedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
