jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/384247 )
Change subject: Improve some parameter docs
......................................................................
Improve some parameter docs
Change-Id: Icddf00ac115bbf2feb26fd4f0a17ea6374162262
---
M WMFSite.php
M addWiki.php
M dumpInterwiki.php
M makeSizeDBLists.php
M passwordAudit.php
M phpcs.xml
6 files changed, 9 insertions(+), 11 deletions(-)
Approvals:
Brian Wolff: Looks good to me, approved
jenkins-bot: Verified
diff --git a/WMFSite.php b/WMFSite.php
index e937e29..8737c95 100644
--- a/WMFSite.php
+++ b/WMFSite.php
@@ -8,7 +8,7 @@
/**
* @param string $suffix
- * @param $prefix
+ * @param string $prefix
* @param string $url
*/
function __construct( $suffix, $prefix, $url ) {
diff --git a/addWiki.php b/addWiki.php
index 5695d35..391a919 100644
--- a/addWiki.php
+++ b/addWiki.php
@@ -46,7 +46,7 @@
* Used as an override from SQL commands in tables.sql being executed.
* In this cases, index creations on the searchindex table
*
- * @param $cmd string
+ * @param string $cmd
* @return bool
*/
public function noExecuteCommands( $cmd ) {
diff --git a/dumpInterwiki.php b/dumpInterwiki.php
index 055536f..49ed193 100644
--- a/dumpInterwiki.php
+++ b/dumpInterwiki.php
@@ -417,8 +417,8 @@
/**
* Executes part of an INSERT statement, corresponding to all
interlanguage links to a particular site
*
- * @param $site WMFSite
- * @param $source
+ * @param WMFSite &$site
+ * @param string $source
*/
function makeLanguageLinks( &$site, $source ) {
global $wmfRealm;
@@ -443,8 +443,8 @@
}
/**
- * @param $entry
- * @param $source
+ * @param array $entry
+ * @param string $source
* @throws MWException
*/
function makeLink( $entry, $source ) {
diff --git a/makeSizeDBLists.php b/makeSizeDBLists.php
index 353554f..beafb9c 100644
--- a/makeSizeDBLists.php
+++ b/makeSizeDBLists.php
@@ -49,8 +49,8 @@
}
/**
- * @param $filename string
- * @param $items array
+ * @param string $filename
+ * @param array $items
*/
private function writeFile( $filename, $items ) {
$file = fopen( $filename, 'w' );
diff --git a/passwordAudit.php b/passwordAudit.php
index c819f96..1d2b9a9 100644
--- a/passwordAudit.php
+++ b/passwordAudit.php
@@ -94,7 +94,7 @@
/**
* @param string $hash
- * @param $test
+ * @param string $test
* @return bool
*/
public function fastPbkdf2test( $hash, $test ) {
diff --git a/phpcs.xml b/phpcs.xml
index 06e835c..8e111ee 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -4,8 +4,6 @@
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamName" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
<exclude
name="MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures"
/>
<exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
<exclude name="MediaWiki.Files.ClassMatchesFilename.WrongCase"
/>
--
To view, visit https://gerrit.wikimedia.org/r/384247
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icddf00ac115bbf2feb26fd4f0a17ea6374162262
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaMaintenance
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: Brian Wolff <bawolff...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
