MaxSem has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385116 )
Change subject: Get rid of double-escaping
......................................................................
Get rid of double-escaping
Title fragment isn't supposed to be escaped on input. It gets escaped later,
when getFullURL() gets called on the title. This previously didn't matter much
because Sanitizer::escapeId() doesn't break anything if called repeatedly.
However,
now it's deprecated anyway and uses legacy encoding so I need to get rid of it.
Change-Id: I6392604ac0841ae92a21ecb569c9643d7bc6231c
---
M includes/formatters/PresentationModelSectionTrait.php
1 file changed, 1 insertion(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/16/385116/1
diff --git a/includes/formatters/PresentationModelSectionTrait.php
b/includes/formatters/PresentationModelSectionTrait.php
index 7d0e6b9..9a18639 100644
--- a/includes/formatters/PresentationModelSectionTrait.php
+++ b/includes/formatters/PresentationModelSectionTrait.php
@@ -71,10 +71,7 @@
$title = $this->event->getTitle();
$section = $this->getParsedSectionTitle();
// Like Parser::guessSectionNameFromWikiText() but without the
link stripping
- $fragment = Sanitizer::escapeId(
- Sanitizer::normalizeSectionNameWhitespace( $section ),
- 'noninitial'
- );
+ $fragment = Sanitizer::normalizeSectionNameWhitespace( $section
);
if ( $section ) {
$title = Title::makeTitle(
$title->getNamespace(),
--
To view, visit https://gerrit.wikimedia.org/r/385116
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6392604ac0841ae92a21ecb569c9643d7bc6231c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: MaxSem <maxsem.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
